Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupwin (Clean up) doesn't remove materials (as advertised) #176

Open
m-7761 opened this issue Feb 22, 2022 · 0 comments
Open

Groupwin (Clean up) doesn't remove materials (as advertised) #176

m-7761 opened this issue Feb 22, 2022 · 0 comments

Comments

@m-7761
Copy link

m-7761 commented Feb 22, 2022

https://github.com/zturtleman/mm3d/blob/53b0d1b33412bddacd65559f41d5511b9050a27a/src/implui/groupclean.cc#L73-L88

The basic problem is the materials need to be removed last since they depend on groups owning them. But it seems like the removal functions both need to run after the uniqueness ones. I don't know. It might need more thought. (Another thing I just removed is the propEqual function tests for PropSelection/Visibility which are more than likely to only foil a test in real scenario... this is hardly used, but I changed the default to "PropAllSuitable" to remove these from the propEqual parameter defaults. This clean up function is the only thing that uses propEqual that I can see.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant