Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is attr_val_guess_gain properly handling None probabilities? #31

Closed
cmaclell opened this issue Sep 21, 2016 · 2 comments
Closed

Is attr_val_guess_gain properly handling None probabilities? #31

cmaclell opened this issue Sep 21, 2016 · 2 comments

Comments

@cmaclell
Copy link
Owner

I'm not sure, I suspect what we have works, but isn't 100% correct.

@eharpste
Copy link
Collaborator

eharpste commented Apr 7, 2017

@cmaclell thinks this one might be solved but double check.

@cmaclell
Copy link
Owner Author

I believe we're good going to close this issue. I can't remember the exact changes made here, but it loos like we no longer use attr_value_guess_gain. Now we just copy the node, add the instance, then compute the expected correct guesses. My guess is that we did this to avoid exactly this issue of missing values being handled properly.

Also, based on this discussion I added #78 to explore multiple ways to handle missing values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants