Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed parameter and kwargs to Pack #184

Merged
merged 14 commits into from
Jan 30, 2025

Conversation

StephMcCallum
Copy link
Contributor

Solves #183.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Left some comments

flowermd/base/system.py Show resolved Hide resolved
flowermd/base/system.py Show resolved Hide resolved
flowermd/tests/base/test_system.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (a600b73) to head (68f8dc6).
Report is 55 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   94.77%   94.90%   +0.13%     
==========================================
  Files          26       26              
  Lines        1970     2023      +53     
==========================================
+ Hits         1867     1920      +53     
  Misses        103      103              
Files with missing lines Coverage Δ
flowermd/base/system.py 92.41% <100.00%> (+0.02%) ⬆️

Copy link
Member

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@StephMcCallum StephMcCallum merged commit d3497a2 into cmelab:main Jan 30, 2025
10 checks passed
@StephMcCallum StephMcCallum deleted the add_pack_seed branch January 30, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants