Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not include wall forces when pickling the forcefield #51

Closed
chrisjonesBSU opened this issue Sep 18, 2023 · 0 comments · Fixed by #149
Closed

Option to not include wall forces when pickling the forcefield #51

chrisjonesBSU opened this issue Sep 18, 2023 · 0 comments · Fixed by #149
Assignees
Labels
good first issue Good for newcomers

Comments

@chrisjonesBSU
Copy link
Member

Right now, when pickling the force field, the entire list of forces is saved. Sometimes a force is added automatically behind the scenes (adding walls for slab and weld simulations) that we don't want to reuse in a separate simulation. Right now, wall forces are the only ones automatically added, so I'm thinking we just have a parameter like exclude_walls in the pickle_forcefield() method.

@chrisjonesBSU chrisjonesBSU self-assigned this Sep 18, 2023
@chrisjonesBSU chrisjonesBSU added the good first issue Good for newcomers label Nov 14, 2023
@chrisjonesBSU chrisjonesBSU linked a pull request Jul 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant