-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add classes for simulating ellipsoid polymer systems. #102
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 94.40% 94.75% +0.35%
==========================================
Files 25 26 +1
Lines 1840 1965 +125
==========================================
+ Hits 1737 1862 +125
Misses 103 103
|
I'm not so sure about the code snippet in I can work on adding a tutorial for the time being since we are waiting to merge this until the JOSS submission is finished. Other than that, I still think we may need some more sanity checks, so some simulations ran and see if things make sense. |
Yeah we can definitely add the tutorial for now and make it more comprehensive once we added the support for rigid body simulation for all types of molecules in flowermd . |
for more information, see https://pre-commit.ci
… orientaiton to rigid body util
for more information, see https://pre-commit.ci
This PR adds 2 new classes to the flowerMD library.
flowermd.library.polymers.EllipsoidChain
flowermd.library.forcefields.EllipsoidForcefield
These pull from the work I started in the polyellipsoid repo, but implements both the chain construction and forcefield here following flowermd design choices.
The main to-do remaining is deciding when, where and how we want to add the rigid body steps required. I think we should aim for not having to create a new
System
class that handles the remaining rigid body stuff, but figure out another way to handle it (a utils file, adding rigid body labeling toMolecule
and/orPolymer
, a flag inSystem
to handle it, etc...)Just a reminder, the ellipsoid "monomers" here have 3 kinds of particles: