We can now use two GSD files in welding.Interface
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 94.28% 94.38% +0.10%
==========================================
Files 25 25
Lines 1801 1834 +33
==========================================
+ Hits 1698 1731 +33
Misses 103 103
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, only a single
gsdfile could be passed toInterfaceand it would be duplicated to make an interface system. This PR lets you pass either 1 or 2gsdfiles and either builds the interface by replicating one, or using both. There are still come constraints (assume each gsd file has the same box size and number of particles), but for now, I think these can be addressed in a separate PR. I can open an issue about it.To do: