Bug report: no error thrown by clusterAnaScurve.py if $DATA_PATH does not have expected substructure

[ElizabethRoseStarling]

When attempting to submit cluster jobs for the purpose of analyzing the full history of SCurve scans for a given detector, the process given here (https://github.com/cms-gem-daq-project/gem-plotting-tools#full-example-for-p5-s-curve-data) does not require a user specify a data path. Rather, it assumes the data path is /afs/cern.ch/.../CMS_GEM/Data/gemdata

Types of issue

• [] Bug report (report an issue with the code)
• Feature request (request for change which adds functionality)

Expected Behavior

If no data is found in the expected path, there should be some error message warning the user to set the correct data path.

Current Behavior

If the user's data is located in a different path, the cluster submission will exit with "Job submission completed" and not provide any errors, despite no jobs being actually submitted.

Context (for feature requests)

I am trying to analyze the full history of SCurve scans on each of the slice test detectors.

Your Environment

Cluster submissions on LXPlus

[bdorney]

To clarify the issue is that if the user sets $DATA_PATH to a directory in which the immediate sub-directories do not include the expected sub-structure, e.g.:

• $DATA_PATH/GEMINImXLY/scurve

the script, clusterAnaScurve.py, will run, launch zero jobs, and will not throw an exception or print an error message. It looks like lines 129-132 should be reworked to include an error message. Right now they just skip the given (chamberName, scandate) pair to ensure successful jobs are submitted.

gem-plotting-tools/macros/clusterAnaScurve.py

Lines 129 to 132 in e293909

	if not filePathExists(dirPath, tree_names[options.anaType][0]):
	outputScanDatesFile.write('#%s\t%s\n'%(chamberAndScanDatePair[0],chamberAndScanDatePair[1]))
	continue
	outputScanDatesFile.write('%s\t%s\n'%(chamberAndScanDatePair[0],chamberAndScanDatePair[1]))

Or further upstream in the script a check should be made.