Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airlocks go into an infinite open/close loop when being blocked by a shutter #7769

Closed
3 tasks done
Blundir opened this issue Dec 9, 2024 · 0 comments · Fixed by #7771
Closed
3 tasks done

Airlocks go into an infinite open/close loop when being blocked by a shutter #7769

Blundir opened this issue Dec 9, 2024 · 0 comments · Fixed by #7771
Labels
Bug Admin events aren't bugs

Comments

@Blundir
Copy link
Contributor

Blundir commented Dec 9, 2024 •
edited
Loading

Testmerges

#7536, #7598, #7165

Round ID

25307

Description of the bug

Airlock cannot fully close while being closed a shutter, trying to close and opening forever.

What's the difference with what should have happened?

Door shoot either not go into a loop or just close normally disregarding shutter blocking it.

How do we reproduce this bug?

  1. Find a door that has a shutter in the same tile (i.e. CL's office and research has a lot of them)
  2. Close the shutters with a door still open
  3. Airlock goes into a loop of trying to close, not being able to close due to shutter blocking it and openining again because of that

Issue Bingo
@Blundir Blundir added the Bug Admin events aren't bugs label Dec 9, 2024
@Drulikar Drulikar mentioned this issue Dec 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2024
@Drulikar
Door Stuck Pt3: Shutter Handling (#7771)
f554c77 
# About the pull request

This PR is a follow up to #7749 and #7727 adding another exemption to
what should not block a door closing: shutters. I am assuming any
anchored door in the locs of the door can be deemed a shutter, but need
be we can explicitly check for pod doors.

# Explain why it's good for the game

Fixes #7769 

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

https://youtu.be/5TWtsn3tDX4

</details>


# Changelog
:cl: Drathek
fix: Fixed doors considering shutters as blocking
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Door Stuck Pt3: Shutter Handling Drulikar/cmss13
1 participant
@Blundir