Broiler-T Pyro backpack doesn't accept custom tanks

[cm13-issue-bot]

Testmerges

#7536: 'Adds crosshairs to all ranged weapons' by VileBeggar at commit d8bd7437c4
#7766: 'lobby screen update' by harryob at commit 61b278ed88
#7754: 'Adds Watchtowers' by Git-Nivrak at commit 61479579ab
#7802: 'Removes non combat click delay' by Git-Nivrak at commit add0b48a4b
#7607: 'Warden Praetorian rework (tm)' by Red-byte3D at commit 6679548f3b
#7600: 'SG Frontline Mode & Friends - Yay!!!' by BasilHerb at commit cfdd191899
#7743: 'Ship Operations Synthetic' by QuickLode at commit ac99415374
#7764: '[TM only] Snowflake_SnowCap' by HIDgamer at commit 364f8cccd3
#7165: 'Fax Responders TestMerge Collection' by realforest2001 at commit 3543d15488
#7901: 'Adds a speed penalty to incomplete Yautja field surgery.' by realforest2001 at commit 3c7eab0096
#7774: 'req console tgui' by harryob at commit a04d077fca
#7242: 'WIP Yautja Clan TGUI Menu' by realforest2001 at commit 636f4413af
#7568: 'adds a tgui for the pred preferences menu' by harryob at commit 130b54381e
#7909: 'Fixes maintainer access to the profiler and clears profiler access whenever admins are loaded.' by Watermelon914 at commit 6f3a0a64f4
#7913: 'Fixes santa hat inhands + makes it hide only top hair' by Blundir at commit a89b56b14f

Round ID

25600

Description of the bug

You cannot use custom OT tanks made for the linked M-240T on the Broiler system, it refuses to accept them.

In order to equip OT tanks you have to entirely remove the Broiler backpack, manually insert the OT tank into the M-240T and then it works properly, but the moment you put on the Broiler-T on your backpack slot the OT tank is removed from the weapon.

What's the difference with what should have happened?

A tank is expelled while the OT tank is accepted in it's place

How do we reproduce this bug?

1. Grab proper OT tank that is compatible for the M-240T
2. Try and insert it into the Broiler-T
3. Remove the Broiler-T from the backpack slot
4. Insert OT tank into M240-T held in hand
5. Put on the Broiler-T backpack

Attached logs

N/A

Additional details

• Author: DaTimeSmog
• Admin: Segrain
• Note: None

[Weuyn]

/obj/item/weapon/gun/flamer/M240T/Fire(atom/target, mob/living/user, params, reflex = 0, dual_wield)
    if (!link_fuelpack(user) && !current_mag)
        to_chat(user, SPAN_WARNING("You must equip the specialized Broiler-T back harness or load in a fuel tank to use this incinerator unit!"))
        click_empty(user)
        return
    if (fuelpack)
        // Check we're actually firing the right fuel tank
        if (current_mag != fuelpack.active_fuel)
            // This was a manually loaded fuel tank
            if (current_mag && !(current_mag in list(fuelpack.fuel, fuelpack.fuelB, fuelpack.fuelX)))
                to_chat(user, SPAN_WARNING("\The [current_mag] is ejected by the Broiler-T back harness and replaced with \the [fuelpack.active_fuel]!"))
                unload(user, drop_override = TRUE)
            current_mag = fuelpack.active_fuel
            update_icon()
    return ..()

This is the part that handles manually loaded tanks that force ejects anything that isn't b gel, x fuel or regular fuel (even normal incinerator tanks filled with HC napalm get ejected), I've tried to fix it but I am an illiterate medieval peasant when it comes to coding.

[rintherat]

/obj/item/weapon/gun/flamer/M240T/Fire(atom/target, mob/living/user, params, reflex = 0, dual_wield)
    if (!link_fuelpack(user) && !current_mag)
        to_chat(user, SPAN_WARNING("You must equip the specialized Broiler-T back harness or load in a fuel tank to use this incinerator unit!"))
        click_empty(user)
        return
    if (fuelpack)
        // Check we're actually firing the right fuel tank
        if (current_mag != fuelpack.active_fuel)
            // This was a manually loaded fuel tank
            if (current_mag && !(current_mag in list(fuelpack.fuel, fuelpack.fuelB, fuelpack.fuelX)))
                to_chat(user, SPAN_WARNING("\The [current_mag] is ejected by the Broiler-T back harness and replaced with \the [fuelpack.active_fuel]!"))
                unload(user, drop_override = TRUE)
            current_mag = fuelpack.active_fuel
            update_icon()
    return ..()

This is the part that handles manually loaded tanks that force ejects anything that isn't b gel, x fuel or regular fuel (even normal incinerator tanks filled with HC napalm get ejected), I've tried to fix it but I am an illiterate medieval peasant when it comes to coding.

The reason why broiler packs cannot use it is because of the way /obj/item/large_holster/fuelpack is designed; it has a if() else if switch that cycles thru the tanks by /obj/item/storage/large_holster/fuelpack/proc/do_toggle_fuel(mob/user). Custom tanks are not included, and therefore can never be selected.