Beta 516: Chat preferences reset on server restart

[MistChristmas]

Testmerges

#7909, #7850, #7716, #7165, #7946, #8007, #7607, #8034, #8015, #7511, #8049

Round ID

25805

Description of the bug

Joining back after a server restart seems to get rid of your chat preferences.
Refreshing TGUI also seems to do this.

Rejoining afterwards sometimes fixes this? Inconsistent.
Joining your local if you have your preferences there might carry them over? This might just be placebo for joining somewhere else and coming back.

What's the difference with what should have happened?

Preferences shouldn't reset to default

How do we reproduce this bug?

1. Be on Beta
2. Wait for a server restart, or a need to refresh TGUI
3. Have to set up your chat preferences again.
4. Alternatively joining your local seems to have preferences saved which carries over?.
   ...

Issue Bingo

• Issue could be reproduced at least once
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)

[MistChristmas]

Seems it was just placebo. And re-joining does make them come back. Most of the time.

[harryob]

isolated this to a byond issue on 516, https://www.byond.com/forum/post/2959743

[harryob]

will be resolved after updating to 515.1640 (when that is available)