Skip to content

Commit

Permalink
Merge pull request #272 from cmu-delphi/finalMainUpdates
Browse files Browse the repository at this point in the history
updating release process
  • Loading branch information
dsweber2 authored Mar 4, 2024
2 parents 540b6a4 + 8405a20 commit 5f35c0d
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 25 deletions.
8 changes: 0 additions & 8 deletions .bumpversion.cfg

This file was deleted.

50 changes: 33 additions & 17 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## Setting up the development environment

```r
install.packages(c('devtools', 'pkgdown', 'styler', 'lintr')) # install dev dependencies
pak::pkg_install(c('devtools', 'pkgdown', 'styler', 'lintr')) # install dev dependencies
devtools::install_deps(dependencies = TRUE) # install package dependencies
devtools::document() # generate package meta data and man files
devtools::build() # build package
Expand Down Expand Up @@ -45,20 +45,36 @@ python -m http.server -d docs
Please follow the guidelines in the [PR template document](.github/pull_request_template.md).

## Release process
First, there's a handy function that makes a github issue; for example, at the time of writing we were doing:
```R
usethis::use_release_issue(version = "1.0.2")
```
If you want to extend it, add to the `release_bullets` function in [utils.R](https://github.com/cmu-delphi/epidatr/blob/dev/R/utils.R).
First, make sure that all the checks pass

```R
devtools::check(".", manual = TRUE, env_vars =c(NOT_CRAN = "false"))
```

Aim for 10/10, no notes. Generally, follow the issue. `revdep_check` is likely to fail but doesn't seem to be terribly important. So for now ignore it.

When this has gone smoothly enough, release to CRAN via
```R
devtools::release(check = TRUE)
```
Open a release issue and then copy and follow this checklist in the issue (modified from the checklist generated by `usethis::use_release_issue(version = "1.0.2")`):

- [ ] `git pull`
- [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_epidatr.html)
- [ ] `devtools::check(".", manual = TRUE, env_vars = c(NOT_CRAN = "false"))`.
- Aim for 10/10, no notes.
- [ ] If check works well enough, merge to main. Otherwise open a PR to fix up.
- [ ] [Polish NEWS](https://github.com/cmu-delphi/epidatr/blob/dev/NEWS.md).
- Some [guidelines](https://style.tidyverse.org/news.html#news-release).
- [ ] `git checkout main`
- [ ] `git pull`
- [ ] `urlchecker::url_check()`.
- This may choke on the MIT license url, and that's ok.
- [ ] `devtools::build_readme()`
- [ ] `devtools::check_win_devel()`
- [ ] Check email for problems
- [ ] `revdepcheck::revdep_check(num_workers = 4)`.
- This may choke, it is very sensitive to the binary versions of packages on a given system. Either bypass or ask someone else to run it if you're concerned.
- [ ] Update `cran-comments.md`
- [ ] PR with any changes

Submit to CRAN:

- [ ] `devtools::submit_cran()`
- [ ] Approve email

Wait for CRAN...

- [ ] Accepted :tada:
- [ ] `dev`
- [ ] `usethis::use_github_release(publish = FALSE)` (publish off, otherwise it won't push).
- [ ] check the release notes and publish the branch on github
2 changes: 2 additions & 0 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ pak::pkg_install("epidatr")
pak::pkg_install("cmu-delphi/epidatr@dev")
```

Our CRAN listing is [here](https://cran.r-project.org/web/packages/epidatr/index.html).

### API Keys

The Delphi API requires a (free) API key for full functionality. To generate
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ pak::pkg_install("epidatr")
pak::pkg_install("cmu-delphi/epidatr@dev")
```

Our CRAN listing is
[here](https://cran.r-project.org/web/packages/epidatr/index.html).

### API Keys

The Delphi API requires a (free) API key for full functionality. To
Expand Down

0 comments on commit 5f35c0d

Please sign in to comment.