Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add print methods for rest of custom classes #232

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Add print methods for rest of custom classes #232

merged 7 commits into from
Jan 8, 2024

Conversation

nmdefries
Copy link
Contributor

Closes #51

brookslogan
brookslogan reviewed Jan 4, 2024
View reviewed changes
brookslogan
brookslogan requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rounding out of the print functionality. There appears to be some bugs with epiweek printing, plus some lower-priority annoying stuff that likely happens if you try to use this in an Rmd/qmd.

@nmdefries nmdefries requested a review from brookslogan January 4, 2024 21:55
@nmdefries nmdefries merged commit ff68c45 into dev Jan 8, 2024
10 checks passed
@nmdefries nmdefries deleted the ndefries/class-print branch January 8, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

@brookslogan brookslogan brookslogan approved these changes

@dsweber2 dsweber2 Awaiting requested review from dsweber2 dsweber2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add print S3 methods for any classes missing them (e.g., EpiRange)
3 participants
@nmdefries @dshemetov @brookslogan