Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audited examples in endpoint.r, see TODO items for further edits needed. #293

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

tinatownes
Copy link
Collaborator

@tinatownes tinatownes commented Sep 3, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current epidatr main reviewers:
    brookslogan, dshemetov, nmdefries, dsweber2.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@nmdefries
Copy link
Contributor

@dshemetov Can you take a look at this?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this so you can just merge after fixing, but please make sure to address the two minor issues (both URLs) I raised before merging. The CRAN url in particular will make the next release harder if not addressed.

Co-authored-by: Dmitry Shemetov <[email protected]>
@nmdefries nmdefries merged commit 0b34808 into dev Sep 26, 2024
8 checks passed
@nmdefries nmdefries deleted the Tina_endpoints_examples_audit branch September 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants