-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audited examples in endpoint.r, see TODO items for further edits needed. #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinatownes
requested review from
dshemetov,
brookslogan,
dsweber2 and
nmdefries
as code owners
September 3, 2024 01:56
nmdefries
force-pushed
the
Tina_endpoints_examples_audit
branch
from
September 3, 2024 19:01
7dd4b89
to
ea699cd
Compare
@dshemetov Can you take a look at this? |
nmdefries
force-pushed
the
Tina_endpoints_examples_audit
branch
from
September 3, 2024 19:06
ed22841
to
99ea645
Compare
dshemetov
reviewed
Sep 26, 2024
dshemetov
reviewed
Sep 26, 2024
dshemetov
reviewed
Sep 26, 2024
dshemetov
reviewed
Sep 26, 2024
dshemetov
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve this so you can just merge after fixing, but please make sure to address the two minor issues (both URLs) I raised before merging. The CRAN url in particular will make the next release harder if not addressed.
Co-authored-by: Dmitry Shemetov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, dshemetov, nmdefries, dsweber2.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch