Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use delphidocs #296

Merged
merged 20 commits into from
Nov 14, 2024
Merged

Use delphidocs #296

merged 20 commits into from
Nov 14, 2024

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

This is against main. It should update the rendered site. Then merge this back on to dev.

  • Request a review from one of the current epidatr main reviewers:
    brookslogan, dshemetov, nmdefries, dsweber2.
  • XX Makes sure to bump the version number in DESCRIPTION. No functional changes

Change explanations for reviewer

See commit messages.

dsweber2 and others added 13 commits June 20, 2024 14:22
@dsweber2
CRAN submission for 1.2.0
3fe43da
@dshemetov
docs: improve strange wording on getting started page
d2995c7 
Found some strange wording in the migration to epidatpy.
@dshemetov
Merge pull request #292 from cmu-delphi/dshemetov-patch-1
2ee8867 
docs: improve strange wording on getting started page
@tinatownes
Audited examples in endpoint.r, see TODO items for further edits needed.
c98bd43
@nmdefries
fix broken examples
ea699cd
@nmdefries
linting
99ea645
@nmdefries
docs: document (GHA)
f4139f8
@nmdefries @dshemetov
update links
cdd2ef3 
Co-authored-by: Dmitry Shemetov <[email protected]>
@nmdefries
Merge pull request #293 from cmu-delphi/Tina_endpoints_examples_audit
0b34808 
Audited examples in endpoint.r, see TODO items for further edits needed.
@dajmcdon
check .Rprog into version control
220f671
@dajmcdon
add template pkg to description, clean with usethis::use_tidy_descrip…
aaca479 
…tion()
@dajmcdon
document()
09ba648
@dajmcdon
delphidocs pkg, mv related down the sidebar
0dd6f14
dshemetov
dshemetov reviewed Nov 14, 2024
View reviewed changes
dshemetov
dshemetov approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@dajmcdon dajmcdon merged commit b998e1d into main Nov 14, 2024
17 checks passed
@dajmcdon dajmcdon deleted the use-delphidocs branch November 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

@brookslogan brookslogan Awaiting requested review from brookslogan brookslogan is a code owner

@dsweber2 dsweber2 Awaiting requested review from dsweber2 dsweber2 is a code owner

@nmdefries nmdefries Awaiting requested review from nmdefries nmdefries is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dajmcdon @dshemetov @dsweber2 @tinatownes @nmdefries