Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use delphidocs #297

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Use delphidocs #297

merged 11 commits into from
Nov 14, 2024

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current epidatr main reviewers:
    brookslogan, dshemetov, nmdefries, dsweber2.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

README.md Outdated Show resolved Hide resolved
@dajmcdon
Copy link
Contributor Author

@dshemetov Do you mind debugging the failing Check? It's one of the tests getting a different API error code than expected.

@dshemetov
Copy link
Contributor

We can just ignore it, it's trying to ping https://httpbin.org/status/414 and the site is down. Honestly, should probably just remove that test.

@dajmcdon dajmcdon merged commit 0026856 into dev Nov 14, 2024
17 checks passed
@dajmcdon dajmcdon deleted the use-delphidocs branch November 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants