Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add elastic ip for Grafana #69

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Feb 26, 2024

What type of PR is this?

kind/feature

What this PR does / why we need it:

This creates an Equinix elastic IP named monitoring and assigns it to the node where Grafana is deployed.

This will allow us to request a DNS record for green-reviews.tag-env-sustainability.cncf.io

Which issue(s) this PR fixes:

Towards #31

Special notes for your reviewer (optional):

k get no -o wide
NAME                              STATUS   ROLES                  AGE   VERSION        INTERNAL-IP     EXTERNAL-IP     OS-IMAGE             KERNEL-VERSION      CONTAINER-RUNTIME
green-reviews-worker-falco-a      Ready    <none>                 26m   v1.29.0+k3s1   147.28.133.63   <none>          Ubuntu 22.04.4 LTS   5.15.0-94-generic   containerd://1.7.11-k3s2
green-reviews-worker-internal-1   Ready    <none>                 25m   v1.29.0+k3s1   147.28.134.59   147.28.133.50   Ubuntu 22.04.4 LTS   5.15.0-94-generic   containerd://1.7.11-k3s2
green-reviews-control-plane       Ready    control-plane,master   28m   v1.29.0+k3s1   147.28.134.47   <none>          Ubuntu 22.04.4 LTS   5.15.0-94-generic   containerd://1.7.11-k3s2

Signed-off-by: Ross Fairbanks <[email protected]>
Signed-off-by: Ross Fairbanks <[email protected]>
@rossf7
Copy link
Contributor Author

rossf7 commented Feb 28, 2024

@nikimanoledaki @AntonioDiTuri Like we discussed I've updated to use a global IP for the elastic IP. In case we want to move region for the cluster for #4

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point we may want to move the scripting out of openTofu and into Ansible or some other tool that is better suited for this kind of job.

@leonardpahlke
Copy link
Member

Feel free to merge whenever

Copy link
Contributor

@guidemetothemoon guidemetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 😊

@rossf7 rossf7 merged commit 05571b9 into cncf-tags:main Mar 5, 2024
1 check passed
@rossf7 rossf7 deleted the feat/elastic-ip branch March 5, 2024 13:08
@rossf7
Copy link
Contributor Author

rossf7 commented Mar 5, 2024

@leonardpahlke Yes, unfortunately the elastic IP isn't added automatically. So more bash was needed than I'd prefer.

Good idea to revisit this when we have more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants