Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed several translations with better English #81

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fixed several translations with better English #81

wants to merge 11 commits into from
+2,046 −1,144

Conversation

Raymo111
Copy link

Including grammar sentence structure, localized descriptions and capitalization

cnwangjie and others added 11 commits October 23, 2018 20:12
@cnwangjie
change: main page use drawer & some perf improve
ca29cc9 
 - perf: dynamic import template & split chunks with popup page
 - change: use drawer & primary color
 - feat: allow import / export file
@cnwangjie
refactor front-end styles & features
2457a83 
 - feat: multi items operations
 - feat: detail list pagination
 - feat: hide too much items in detail list
 - refactor: search feature can be used in every page
 - refactor: use drawer
 - depracate: some options have be depracated (removeItemBtnPos, fixedToolbar, enableSearch)
@cnwangjie
refactor list modifier & sync logic
1a42942
@cnwangjie
apply new sync / auth logic & migrate functions
1d16421
@cnwangjie
avoid apply changes to app data twice & fix some bugs in detail list
45f13ac
@cnwangjie
fix: expand status changed can not be stored & show more button display
6375583
Re translated form Chinese and fixed some grammar issues, added link …
284175d 
…to MIT license
FInished correcting Readme
202706f
Formatted Bug report
f7b781e 
Added better English Translation and examples
Fixed translations
25e0fb5 
Added better and clearer English Translations, fixed grammar and capitalization
Fixed name for consistency
5270fcf
cnwangjie
cnwangjie reviewed Dec 13, 2018
View reviewed changes
Copy link
Owner

@cnwangjie cnwangjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your works. But I don't think the most parts of those need to be modified. Maybe I'll use some parts of them. :)

.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
src/_locales/en/messages.json Show resolved Hide resolved
@Raymo111
Copy link
Author

Sure, just use whatever you need. In my opinion the English could be improved, but it's up to you.

@onefork
Copy link

onefork commented Jan 31, 2019

Thanks a lot.

It's still a little bit confusing on the option page.

Under "Behaviour"
Behavior when item in a list is clicked: The options are "open" and "open and remove"
Behavior when item in simple list is clicked: "restore" and "restore in new window"

"An item in a list" means a tab in a tab group while "an item in a simple list" is a tab group, right?
And the "open and remove" option doesn't seem to remove anything.

Best

@kickformoney
Copy link

Thanks a lot.

It's still a little bit confusing on the option page.

Under "Behaviour"
Behavior when item in a list is clicked: The options are "open" and "open and remove"
Behavior when item in simple list is clicked: "restore" and "restore in new window"

"An item in a list" means a tab in a tab group while "an item in a simple list" is a tab group, right?
And the "open and remove" option doesn't seem to remove anything.

Best

The Open and Remove option opens the link in a new tab, then removes it from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnwangjie cnwangjie cnwangjie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Raymo111 @onefork @kickformoney @cnwangjie