Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ConfirmModal 컴포넌트 UI 구현 2. constants 폴더 modal.ts 에 confirm type 분리
kimbobby
requested review from
nakyoung98,
JIS0098,
hankim0904 and
Yoon-kyungLee
올바른 PR 형식올바른 PR 형식입니다. |
|
고생 많으셨습니다 :) |
JIS0098
approved these changes
Mar 12, 2024
Yoon-kyungLee
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌요구사항
📌작업 진행 상황 (에러, 막혔던 부분, 그외 궁금한것 등등)
여러가지 타입의 confirm 모달 내부 텍스트가 아직 미정이라 임의로 넣은 상태입니다.
정해지면 수정해서 반영해놓겠습니다.
📌스크린샷 / 테스트결과 (선택)
2024-03-11.10.14.18.mov
📌이슈 번호
close #25