Feature: Add Item overview and read only detail pages #269
+7,691
−2,584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
API-Client
SchoolGuy
force-pushed
the
feature/add-item-overview
branch
from
3abe8b2
to
6afb794
Compare
SchoolGuy
force-pushed
the
feature/add-item-overview
branch
from
b4deab4
to
86b5aee
Compare
00Kadie00
reviewed
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Open points:
I think the scope of this PR is making the edit functionality work, but it should be taken care of that this is implemented as a no-op already.
Due to two missing UI components (#270, #271), it is also out of scope to display list and dict type attributes.
Edit: I noticed that we also don't have a shared component yet to display if a value is inherited or not. As such this is also out of scope (see #279). This PR should just show the values with their correct datatype if the type is scalar.
Screenshots:
Overview:
Details:
List and Dict View: