Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set kill or restart as default healtcheck action on failure #1252

Open
2 tasks
jelly opened this issue Mar 29, 2023 · 1 comment
Open
2 tasks

Set kill or restart as default healtcheck action on failure #1252

jelly opened this issue Mar 29, 2023 · 1 comment

Comments

@jelly
Copy link
Member

jelly commented Mar 29, 2023

The default action is to do nothing, which is a bit strange as you went to all the trouble to configure a health check.

  • report upstream that the default behaviour does nothing
  • determine if we want to either set kill or restart as action or make setting an action mandatory?

Follow up from a comment by @martinpitt in #1233 (review)_

@garrett you might also have some suggestions/opinion on this topic.

@garrett
Copy link
Member

garrett commented Apr 11, 2023

Cockpit Podman was instructed to run the container, regardless of healthcheck, so if if a healthcheck fails, it probably makes sense to default to restart. (In other words, the machine should probably keep doing as it was told.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants