Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take newer screenshots, show off newer (and older but important) features #778

Open
garrett opened this issue Jan 13, 2025 · 18 comments
Open
Assignees

Comments

@garrett
Copy link
Member

garrett commented Jan 13, 2025

It's been a while since we took screenshots the last time around.

We should update them.

And also, both webp and even avif are now supported screenshot types that are both supported in our target browsers and should compress even better, reducing load times.

https://caniuse.com/webp
https://caniuse.com/avif

@garrett garrett self-assigned this Jan 13, 2025
@Mash707
Copy link
Contributor

Mash707 commented Jan 31, 2025

Hi @garrett , Are we particularly talking about the screenshots that are present on the front page of cockpit or the whole website in general?

@garrett
Copy link
Member Author

garrett commented Feb 4, 2025

Front page especially; the ones in the blog posts are historical relics tied to a release. There might be screenshots elsewhere that could use a freshening up though.

This could (and probably should) be a team effort. I'll add something to the agenda for the weekly meeting about it and see if I can get others in the team to pitch in too.

I was the person who took all the screenshots on the front page previously, IIRC. The general idea was to show off important parts of Cockpit and don't show anything other than Cockpit, unless it's to demonstrate it working in an environment (like, "hey, it works on Windows!" and "hey, it is in a browser that works on Linux too"). That's why it's mainly Cockpit, but also a few with browser UI and even complete desktops sometimes.

We're currently lacking:

  • Recent screenshots overall
  • Cockpit Files
  • Cockpit Podman
  • Showing off a VM running inside of Cockpit Machines
  • The new refreshed accounts page
  • Metrics

We should keep showing off things like the Logs page, Software updating, Firewall, and so on.

@Mash707
Copy link
Contributor

Mash707 commented Feb 4, 2025

So is this something I can work upon or can I participate in the meeting to get a better understanding of what you guys think? I have cockpit installed on my system and have also built it locally.

I can take screenshots from my system. Also is there a particular format of screenshots that you guys look for?

I am also bit confused about what screenshots should we add first or we add them all?

Should I start with replacing already existing screenshots with newer ones?
Thank you.

@garrett
Copy link
Member Author

garrett commented Feb 5, 2025

Oh, the meeting is our internal meeting; and I'm basically going ask the team to participate. If there's anything more than what's outlined here, I'll update the comment above with additional details.

The firewall page requires firewalld, which isn't available everywhere. For example: Fedora has firewalld, but Ubuntu does not, so Ubuntu does not have access to a firewall UI within Cockpit.

@martinpitt
Copy link
Member

Ubuntu does have firewalld, and we test it, it works. But of course it's much less popular there (the recommended/preinstalled thing is ufw). For Debian there's no real default, ufw is more popular than firewalld, but there's a dozen other firewall packages too

@Mash707
Copy link
Contributor

Mash707 commented Feb 5, 2025

I did install firewalld using sudo apt -y install firewalld. I also have ufw preinstalled with Ubuntu in wsl.

Image

How can I confirm it is working in cockpit or not?

@martinpitt
Copy link
Member

@Mash707 You see it on the Networking page, a "Firewall" card where you can click on and get a full firewall page.

@Mash707
Copy link
Contributor

Mash707 commented Feb 5, 2025

@martinpitt while adding a new zone I am getting this error.

Image

while searching I found this issue: firewalld/firewalld#531
Do we a solution for this?

@martinpitt
Copy link
Member

@Mash707 There's no known solution to me -- firewalld fails in WSL2 (at least in the current Ubuntu version), there's little we can do. I propose you ignore the firewall page then, some of us can do them. In yesterday's team meeting we proposed that we spread this out: everyone can do a few screenshots for a particular page (in PNG format, full browser window, not too big) and then attach them into one comment -- i. e. one comment per page. Then we can edit them a bit (like webp conversion) and put them into a PR separately from taking the screenshots.

@Mash707
Copy link
Contributor

Mash707 commented Feb 6, 2025

Overview Page
Image

Are we talking about screenshots like this one? I'll add more if this one is fine

@martinpitt
Copy link
Member

Yes, except for making them a bit smaller -- 1920 width does not fit onto smaller screens, and it doesn't have to be that spaced out. around 1280x1000 perhaps? We currently have a mix of screenshots, some of which include the browser (like yours), some of which don't. I propose to only snapshot the actual content screen for most of them, but for the overview it's nice to have at least one screenshot with the browser UI.

@Mash707
Copy link
Contributor

Mash707 commented Feb 7, 2025

Got it. I'll add some more screenshots with smaller sizes showing only the actual content screen.

@Mash707
Copy link
Contributor

Mash707 commented Feb 8, 2025

Overview Page

Image

@Mash707
Copy link
Contributor

Mash707 commented Feb 8, 2025

Podman containers

Image

@Mash707
Copy link
Contributor

Mash707 commented Feb 8, 2025

File Browser

Image

@Mash707
Copy link
Contributor

Mash707 commented Feb 8, 2025

Login Page

Image

@Mash707
Copy link
Contributor

Mash707 commented Feb 8, 2025

I resized my browser window so that we can minimize the blank spaces. Will add more screenshots soon.
Mentioning #183 for the guidelines regarding screenshots.

@Mash707
Copy link
Contributor

Mash707 commented Feb 9, 2025

Do we need to highlight dark mode screenshots as well? I see only light mode ones on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants