Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: turning off DistSQL gives 7.5% qps boost on oltp_read_only (conjecture: 3.5% cpu on oltp_read_write) #135898

Open
tbg opened this issue Nov 21, 2024 · 0 comments
Open

sql: turning off DistSQL gives 7.5% qps boost on oltp_read_only (conjecture: 3.5% cpu on oltp_read_write) #135898

tbg opened this issue Nov 21, 2024 · 0 comments
Labels
branch-master Failures and bugs on the master branch. C-performance Perf of queries or internals. Solution not expected to change functional behavior. o-perf-efficiency Related to performance efficiency P-2 Issues/test failures with a fix SLA of 3 months T-sql-queries SQL Queries Team

Comments

@tbg
Copy link
Member

tbg commented Nov 21, 2024 •
edited
Loading

In an ad-hoc experiment, changing sql.defaults.distsql to off resulted in a 7.5 improvement in qps, from around 40k to around 43k.1

DistSQL is likely used for the sysbench "range" queries, which scan 100 consecutive keys. It likely makes no sense to use DistSQL here, as the overhead does not get amortized. There are no unbounded scans here either.

Epic: CRDB-42584

Jira issue: CRDB-44780

Footnotes

  1. https://cockroachlabs.slack.com/archives/C07P0CNLP51/p1732192681032459?thread_ts=1732092976.359539&cid=C07P0CNLP51 ↩
@tbg tbg added C-performance Perf of queries or internals. Solution not expected to change functional behavior. branch-master Failures and bugs on the master branch. P-2 Issues/test failures with a fix SLA of 3 months o-perf-efficiency Related to performance efficiency P-1 Issues/test failures with a fix SLA of 1 month and removed P-2 Issues/test failures with a fix SLA of 3 months labels Nov 21, 2024
@exalate-issue-sync exalate-issue-sync bot added P-2 Issues/test failures with a fix SLA of 3 months and removed P-1 Issues/test failures with a fix SLA of 1 month labels Nov 21, 2024
@tbg tbg changed the title sql: turning off DistSQL gives 7.5% qps boost on oltp_read_only sql: turning off DistSQL gives 7.5% qps boost on oltp_read_only (conjecture: 3.5% cpu on oltp_read_write) Nov 21, 2024
@mgartner mgartner added the T-sql-queries SQL Queries Team label Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-performance Perf of queries or internals. Solution not expected to change functional behavior. o-perf-efficiency Related to performance efficiency P-2 Issues/test failures with a fix SLA of 3 months T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgartner @tbg