Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: perturbation test for intent resolution #135937

Open
andrewbaptist opened this issue Nov 21, 2024 · 1 comment · May be fixed by #135969
Open

kv: perturbation test for intent resolution #135937

andrewbaptist opened this issue Nov 21, 2024 · 1 comment · May be fixed by #135969
Assignees
@andrewbaptist
Labels
A-admission-control A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@andrewbaptist
Copy link
Collaborator

andrewbaptist commented Nov 21, 2024 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.
In a customer case, we saw almost 10 billion intents created over multiple ranges over a 5 hour window from a single INSERT INTO ... SELECT FROM statement that was ultimately aborted. We should create a perturbation test that simulates this behavior and validates that whether the intents are cleaned up by either a conflicting higher priority transaction or the mvcc gc queue.

Describe the solution you'd like
We have seen large availability outages due to LSM inversion when the mvcc gc queue cleaned up these intents.

Describe alternatives you've considered
There is an existing test registerIntentResolutionOverload which tests that the LSM does not get too overloaded. We can replace this test with a perturbation test.

Jira issue: CRDB-44796
@andrewbaptist andrewbaptist added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-transactions Relating to MVCC and the transactional model. O-roachtest A-admission-control T-kv KV Team labels Nov 21, 2024
@andrewbaptist andrewbaptist self-assigned this Nov 21, 2024
@kvoli kvoli removed the O-roachtest label Nov 21, 2024
@kvoli
Copy link
Collaborator

kvoli commented Nov 21, 2024

Removing the O-roachtest label otherwise this ends up in the roachtest triage queue here.

andrewbaptist added a commit to andrewbaptist/cockroach that referenced this issue Nov 23, 2024
@andrewbaptist
roachtest: perturbation test for intents
679f3c0 
Adds the test perturbation/*/intents which stresses adding empty rows
with intents to a cluster.

Fixes: cockroachdb#135937

Release note: None
@andrewbaptist andrewbaptist linked a pull request Nov 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewbaptist andrewbaptist

Labels
A-admission-control A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: perturbation test for intents andrewbaptist/cockroach
2 participants
@kvoli @andrewbaptist