Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: panic when decoding table stats can crash the process #135940

Open
rytaft opened this issue Nov 21, 2024 · 0 comments · May be fixed by #135944
Open

sql: panic when decoding table stats can crash the process #135940

rytaft opened this issue Nov 21, 2024 · 0 comments · May be fixed by #135944
Labels
A-sql-table-stats Table statistics (and their automatic refresh). branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@rytaft
Copy link
Collaborator

rytaft commented Nov 21, 2024 •
edited
Loading

We have observed occasional issues in the past where attempting to decode table statistics histograms causes a panic (e.g., #128876). We catch panics in some parts of the stats cache, but there are some paths through the stats cache where panics are not caught. This causes certain operations that access the stats cache to crash the cockroach process. We should add panic catching for these alternate paths.

Jira issue: CRDB-44798
@rytaft rytaft added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-table-stats Table statistics (and their automatic refresh). T-sql-queries SQL Queries Team branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 labels Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Nov 21, 2024
rytaft added a commit to rytaft/cockroach that referenced this issue Nov 21, 2024
@rytaft
sql/stats: add more panic catching to the stats cache
995d2d1 
Fixes cockroachdb#135940

Release note (bug fix): Fixed an issue where corrupted table statistics could
cause the cockroach process to crash.
@rytaft rytaft linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-table-stats Table statistics (and their automatic refresh). branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/stats: add more panic catching to the stats cache rytaft/cockroach
1 participant
@rytaft