Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: util/metric: change preset buckets from NetworkLatencyBuckets to IOLatencyBuckets #107102

Merged
merged 1 commit into from
Jul 20, 2023
Merged

release-22.2: util/metric: change preset buckets from NetworkLatencyBuckets to IOLatencyBuckets #107102

merged 1 commit into from
Jul 20, 2023

Conversation

ericharmeling
Copy link

Backport 1/1 commits from #106193.

/cc @cockroachdb/release

This commit replaces NetworkLatencyBuckets with IOLatencyBuckets as the preset buckets used for the following metrics' histograms:

  • liveness.heartbeatlatency
  • leases.requests.latency
  • kv.prober.read.latency
  • kv.prober.write.latency
  • proxy.conn_migration.attempted.latency

The upper limit on NetworkLatencyBuckets (1s) is too low for these metrics. Bucket size for all preset buckets increases logarithmically (see prometheus.ExponentialBucketsRange), retaining fidelity at the lower-end of buckets.

Fixes #104017.

Release note: None
Release justification: low-risk bug fix

util/metric: remove NetworkLatencyBuckets
5281682 
This commit removes the generated NetworkLatencyBuckets and
replaces their usage with IOLatencyBuckets as the preset
buckets used for the following metrics' histograms:
- `liveness.heartbeatlatency`
- `leases.requests.latency`
- `kv.prober.read.latency`
- `kv.prober.write.latency`
- `proxy.conn_migration.attempted.latency`

The upper limit on NetworkLatencyBuckets (1s) is too low for
all metrics that currently use it. Bucket size for all buckets
generated with `prometheus.ExponentialBucketsRange` (including
IOLatencyBuckets) increases logarithmically, retaining fidelity
at the lower-end of buckets.

Fixes cockroachdb#104017.

Release note: None
@ericharmeling ericharmeling requested a review from a team July 18, 2023 18:57
@ericharmeling ericharmeling requested review from a team as code owners July 18, 2023 18:57
@ericharmeling ericharmeling requested review from Santamaura and removed request for a team July 18, 2023 18:57
@blathers-crl
Copy link

blathers-crl bot commented Jul 18, 2023 •
edited by ericharmeling
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ericharmeling ericharmeling mentioned this pull request Jul 18, 2023
Merged
abarganier
abarganier approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @Santamaura)

@ericharmeling ericharmeling merged commit 11834b9 into cockroachdb:release-22.2 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abarganier abarganier abarganier approved these changes

@Santamaura Santamaura Awaiting requested review from Santamaura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericharmeling @cockroach-teamcity @abarganier