Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use trait options for instruction data in rust renderer #366

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use trait options for instruction data in rust renderer #366

wants to merge 2 commits into from

Conversation

lorisleiva
Copy link
Member

Fixes #339

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 82d04d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lorisleiva lorisleiva marked this pull request as ready for review December 26, 2024 16:05
febo
febo approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@febo febo febo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cann't speciry trait option of InstructionArgs
2 participants
@lorisleiva @febo