Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete IdentityValueNode? #86

Open
lorisleiva opened this issue Jun 19, 2024 · 0 comments
Open

Delete IdentityValueNode? #86

lorisleiva opened this issue Jun 19, 2024 · 0 comments
Labels
proposal Suggesting a change / new feature

Comments

@lorisleiva
Copy link
Member

lorisleiva commented Jun 19, 2024

Since we already have a PayerValueNode, do we also need a IdentityValueNode?

Both of these aim to refer to the "main wallet" we are using. For instance, if you are inside an app, that's the connected wallet. If you are inside a terminal, that's whoever solana address is, etc.

Since Codama was initially created to render Umi packages and Umi distinguishes between the "main wallet that pays for things" (i.e. the payer) and the "main wallet that gets things" (i.e. the identity), there was a need for both nodes.

However, since Codama is now aiming to be a framework agnostic standard that describe programs, does it make sense to still have that distinction regardless of Umi (we can always add that information on the Umi renderer itself to avoid breaking changes).

Personally, I'm on the fence with this one. I still think the distinction makes sense but I'm not sure if having two "main wallet" pointer is more confusing than helping.

@lorisleiva lorisleiva added the proposal Suggesting a change / new feature label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Suggesting a change / new feature
Projects
None yet
Development

No branches or pull requests

1 participant