Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Q -> 2 from #302 [1709855530999] #410

Open
c4-judge opened this issue Mar 7, 2024 · 3 comments
Open

Upgraded Q -> 2 from #302 [1709855530999] #410

c4-judge opened this issue Mar 7, 2024 · 3 comments
Labels
duplicate-45 grade-b Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-judge
Copy link
Contributor

c4-judge commented Mar 7, 2024

Judge has assessed an item in Issue #302 as 2 risk. The relevant finding follows:

[I-01] A user calling claimFees() must always request for less fees than in protocolFees in the UniswapV3Pool. This is not clear in the function spec and is a user inconvenience that can result in a reverting transaction.
@c4-judge c4-judge added the 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value label Mar 7, 2024
c4-judge added a commit that referenced this issue Mar 7, 2024
@c4-judge
gesha17 issue #410 (File generated from upgraded finding by judge Mar…
2476419 
…ioPoneder)
@c4-judge c4-judge closed this as completed Mar 7, 2024
@c4-judge
Copy link
Contributor Author

c4-judge commented Mar 7, 2024

MarioPoneder marked the issue as duplicate of #34

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Mar 14, 2024
@c4-judge
Copy link
Contributor Author

MarioPoneder marked the issue as satisfactory

@CloudEllie CloudEllie added grade-a QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Mar 26, 2024
@c4-judge c4-judge added grade-b and removed grade-a labels Mar 26, 2024
@c4-judge
Copy link
Contributor Author

MarioPoneder marked the issue as grade-b

@C4-Staff C4-Staff reopened this Mar 27, 2024
@C4-Staff C4-Staff added the Q-07 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate-45 grade-b Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CloudEllie @c4-judge @C4-Staff