We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA 38 : unchecked loop increments no valid in solidity > v0.8.22
G01 : Update storage variable once outside of the loop instead of updating it every time in loop it saves 1 SSTORE, 1SLOAD per iteration(Saves ~2200 Gas per iteration)
G03 : Call _getMultiOwnableStorage() one time to fetch storage pointer and avoid extra internal function call
G09 : Do not assign a variable with its default value
Gas optimization are correctly implemented as suggested.
From the difference in gas snapshot there is a slightly decrease of gas usage for the patched version which is to be expected.
Successful Mitigation
The text was updated successfully, but these errors were encountered:
imare issue #11
b9e2807
3docSec marked the issue as satisfactory
Sorry, something went wrong.
No branches or pull requests
Lines of code
Vulnerability details
C4 Issue
QA 38 : unchecked loop increments no valid in solidity > v0.8.22
G01 : Update storage variable once outside of the loop instead of updating it every time in loop it saves 1 SSTORE, 1SLOAD per iteration(Saves ~2200 Gas per iteration)
G03 : Call _getMultiOwnableStorage() one time to fetch storage pointer and avoid extra internal function call
G09 : Do not assign a variable with its default value
Mitigation
Gas optimization are correctly implemented as suggested.
From the difference in gas snapshot there is a slightly decrease of gas usage for the patched version which is to be expected.
Conclusions
Successful Mitigation
The text was updated successfully, but these errors were encountered: