Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signature malleability in FCL.ecdsa_verify #12

Closed
c4-bot-2 opened this issue Apr 10, 2024 · 3 comments
Closed

signature malleability in FCL.ecdsa_verify #12

c4-bot-2 opened this issue Apr 10, 2024 · 3 comments
Labels
bug Something isn't working edited-by-warden grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@c4-bot-2
Copy link
Contributor

See the markdown file with the details of this report here.
@c4-bot-2 c4-bot-2 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 10, 2024
c4-bot-6 added a commit that referenced this issue Apr 10, 2024
@c4-bot-6
imare issue #12
3e85810
c4-bot-8 added a commit that referenced this issue Apr 10, 2024
@c4-bot-8
imare data for issue #12
6dbcadd
c4-bot-4 added a commit that referenced this issue Apr 10, 2024
@c4-bot-4
Report for issue #12 updated by imare
d2643b8
c4-bot-7 added a commit that referenced this issue Apr 10, 2024
@c4-bot-7
Report for issue #12 updated by imare
a78bdbc
@stevieraykatz
Copy link

Yes! We plan on updating our implementation's version of FCL.ecdsa_verify. We have an ongoing conversation with the originator of the contract in this PR and it's possible that we will suggest an additional change.

@c4-judge
Copy link

3docSec marked the issue as grade-c

@c4-judge c4-judge added grade-c unsatisfactory does not satisfy C4 submission criteria; not eligible for awards labels Apr 14, 2024
@3docSec
Copy link

3docSec commented Apr 14, 2024

While the QA finding is valid, I've marked it grade-c as this contest doesn't have a QA pot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working edited-by-warden grade-c QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stevieraykatz @c4-judge @code4rena-admin @c4-bot-2 @3docSec