Resolve promises in suspense docs (remix-run#12531)

* resolve promises * Update contributors.yml
code · Dec 15, 2024 · 5f40814 · 5f40814
1 parent 0a6bdec
commit 5f40814
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/contributors.yml b/contributors.yml
@@ -98,6 +98,7 @@
 - fyzhu
 - fz6m
 - gaspard
+- gavriguy
 - Geist5000
 - gesposito
 - gianlucca

diff --git a/docs/how-to/suspense.md b/docs/how-to/suspense.md
@@ -18,11 +18,11 @@ import type { Route } from "./+types/my-route";
 export async function loader({}: Route.LoaderArgs) {
   // note this is NOT awaited
   let nonCriticalData = new Promise((res) =>
-    setTimeout(() => "non-critical", 5000)
+    setTimeout(() => res("non-critical"), 5000)
   );
 
   let criticalData = await new Promise((res) =>
-    setTimeout(() => "critical", 300)
+    setTimeout(() => res("critical"), 300)
   );
 
   return { nonCriticalData, criticalData };