Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[critical] Modify Asset Declarations to use the new version of Moonsheep #191

Closed
catileptic opened this issue Nov 22, 2019 · 2 comments
Closed
Assignees
Labels
high priority High priority task

Comments

@catileptic
Copy link
Member

The Moonsheep library, which Catalog Politic - Declaratii de avere relies on, has been modified. The external interface has changed, as well as the architecture. As of commit 9c7300d this repository is out of sync with Moonsheep.

In order to close the Issue, the code in this repository must be modified to use the latest version of Moonsheep. The dependency on the Moonsheep library has been modified to use a fork in order to avoid syncing breaking changes. From this point onwards, we need to modify the code inside Declaratii de Avere to work with this version of Moonsheep.

We can use Opora as a working example.

@catileptic catileptic added the high priority High priority task label Nov 22, 2019
@catileptic catileptic self-assigned this Nov 22, 2019
@catileptic
Copy link
Member Author

The project now works with the latest updates in Moonsheep.

We will need to test the interactions, make sure they all work, and then continue development.

@catileptic catileptic pinned this issue Feb 1, 2020
@catileptic
Copy link
Member Author

Seems to be working. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High priority task
Projects
None yet
Development

No branches or pull requests

1 participant