Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix GitHub Action Failure for Welcome Message in DevDisplay #202

Open
1 task done
ishap11 opened this issue Oct 9, 2024 · 4 comments
Open
1 task done

[Bug]: Fix GitHub Action Failure for Welcome Message in DevDisplay #202

ishap11 opened this issue Oct 9, 2024 · 4 comments
Assignees
Labels
bug Something isn't working hacktoberfest2024 Label for tracking contributions and activities during Hacktoberfest 2024 help wanted Extra attention is needed opensource Label is used for Issues and pull request related to all open source contribution.

Comments

@ishap11
Copy link
Contributor

ishap11 commented Oct 9, 2024

What happened?

I found a BUG 🐞
Description:
The welcome message GitHub Action, which is supposed to trigger when a user adds their profile to DevDisplay, is no longer working as expected. It was functioning properly when the project started, but now fails to execute during deployment.

Steps to Reproduce:

  1. Add a profile to DevDisplay.
  2. Expect a welcome message to be triggered via GitHub Action.
  3. Observe that the action fails to send the message.

Expected Behavior: When a user adds their profile, they should receive a welcome message through GitHub.

Actual Behavior: No message is triggered, and the GitHub Action fails during deployment.

Help Needed: If anyone with experience in GitHub Actions can investigate and fix this issue, your contribution would be greatly appreciated!

Add screenshots

image

What browsers are you seeing the problem on?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ishap11 ishap11 added bug Something isn't working help wanted Extra attention is needed hacktoberfest2024 Label for tracking contributions and activities during Hacktoberfest 2024 opensource Label is used for Issues and pull request related to all open source contribution. gssoc-ext labels Oct 9, 2024
@avishek999
Copy link

assign me this please

@omkarvashistha
Copy link
Contributor

omkarvashistha commented Oct 12, 2024

I think this issue might be coming because in github action file we do not have a condition for when the PR gets merged which means the user is added to DevDisplay

so maybe giving this condition might help

if: github.event.pull_request.merged == true && startsWith(github.event.pull_request.title, 'add : username:')

Note : instead of using PR title to identify we can change that condition also

and also we should change pull_request_target: to pull_request as this is more secure

@ishap11
Copy link
Contributor Author

ishap11 commented Oct 13, 2024

📢 Invitation to Join the DevDisplay WhatsApp Community!
We are excited to invite you to join the WhatsApp community of DevDisplay, where developers and contributors come together to collaborate and share their ideas.

Collaborative Support: If you are interested in working together with extensive support, we encourage you to join our community.

Open Source Contribution: If you would like to contribute to the DevDisplay open-source project, your participation is welcomed in our WhatsApp group.

By joining, you will have the opportunity to connect with like-minded individuals, discuss project developments, and contribute to our shared goals.
For more information and to join the community, please visit: Join DevDisplay WhatsApp Community.

We look forward to your participation!

@ishap11
Copy link
Contributor Author

ishap11 commented Oct 21, 2024

Hi @avishek999,
Any updates on the GitHub Action bug regarding the welcome message? Let me know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest2024 Label for tracking contributions and activities during Hacktoberfest 2024 help wanted Extra attention is needed opensource Label is used for Issues and pull request related to all open source contribution.
Projects
None yet
Development

No branches or pull requests

4 participants