Skip to content

Commit

Permalink
Bump apollo-server-express from 2.x to 3.x (#4579)
Browse files Browse the repository at this point in the history
* Bump apollo-server-express from 2.x to 3.x, fix command and remove from dependabot ignore

* Adapt after review
  • Loading branch information
thomashohn authored Nov 14, 2024
1 parent b343cd2 commit 099a698
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ updates:
ignore:
- dependency-name: "escape-string-regexp"
versions: [">=5.0"]
- dependency-name: "apollo-server-express"
versions: [">=3.0"]
- dependency-name: "eslint"
versions: [ ">8.57.0" ]

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"@wdio/selenium-standalone-service": "8.3.2",
"@wdio/utils": "9.2.8",
"@xmldom/xmldom": "0.9.4",
"apollo-server-express": "2.25.3",
"apollo-server-express": "3.13.0",
"chai-as-promised": "7.1.2",
"chai-subset": "1.6.0",
"cheerio": "^1.0.0",
Expand Down
11 changes: 6 additions & 5 deletions test/data/graphql/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ const server = new ApolloServer({
playground: true,
});

server.applyMiddleware({ app });

app.use(middleware);
app.use(router);
module.exports = app.listen(PORT, () => console.log(`test graphQL server listening on port ${PORT}...`));
server.start().then(() => {
server.applyMiddleware({ app });
app.use(middleware);
app.use(router);
module.exports = app.listen(PORT, () => console.log(`test graphQL server listening on port ${PORT}...`));
});

0 comments on commit 099a698

Please sign in to comment.