-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zaunier, Udovicic, Spitschan - 2024 #132
Comments
I have good news @JZauner after the normal wrangling with packages, I only hit one error, which I'll document below, and then I managed to get the same figures as originally provided in the manuscript. I may well be finishing the certificate tomorrow live during the workshop at Rotterdam. |
Set upTo start, I moved the original figures and html to new names, so I could compare my version with the originals:
I then reduced n_samples (line 15, yaml, from 1000 to 10) and then ran the document:
Note: this wasn't reported in the readme (it may well be obvious how to do the rendering). |
Installation problemI liked the use of the pacman package, which was new to me. However, I did get some error messages on the first run:
Reading the source file, I saw the note about the Matrix package. Having seen errors with lme4, I thought it would be sensible to follow the advice to update Matrix and lme4:
This worked. And then the main packages loaded okay. Failure to load the LightLogR package from githubI got this error:
I couldn't see what was run, but luckily the package is also available
That took about 30 minutes to make progress (Eurostar wifi was having problems downloading the packages though...) |
Running the codeAfter installations finished, the code seemed to work, until this chunk:
TO debug this, I needed to run the document using Markdown, rather than quarto (as intermediate variables are kept:
which allowed me to at least debug; I do not understand why valid_Day is supposed to be missing from the tibble, as it seems to be there:
My hack to get the code working was simply to remove the 2nd element of the list from the label argument (see my code); this then allowed the code to complete. Rendering time is just a few minutes. Do. you understand this error @JZauner ? I can't see the reason for it. |
I put the .Rda file in this repo
|
Summaryfigures regenerated fine. Bootstrapping differences are seen in figure 4 -- my answers are based on far fewer samples. |
I encountered an error on line 160 of the master script. Running the following code:
returns the following error:
|
thanks for the great work reproducing the results! line 36 would then change to: and then two new lines: It would be interesting to see whether @mischewu gets the same error regarding the valid_Day column. |
Thanks, the suggestions fixed it. It runs smoothly now, until indeed the error with the valid_day column. That is, without the workaround proposed by @sje30.
|
@sje30 Let me know when the codecheck.yml is ready and I'll render the register locally - the CI still does not work because of rate limits. Save travels! |
https://github.com/codecheckers/ZaunerEtAl_PLoS_ONE_2024/blob/main/codecheck.yml
is up now.
just home...
…On Fri, Nov 29 2024, Daniel Nüst wrote:
@sje30 Let me know when the codecheck.yml is ready and I'll render the register locally - the CI still does not work because of rate limits.
Save travels!
--
Reply to this email directly or view it on GitHub:
#132 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Accepted for publication, currently in contact with author and editor if CODECHECK can be mentioned in the paper.
@sje30 volunteered as codechecker.
Preprint: https://www.researchsquare.com/article/rs-3771881/v1
Repository: https://github.com/tscnlab/ZaunerEtAl_PLoS_ONE_2024 | https://zenodo.org/records/14035243
Certificate:
2024-018
The text was updated successfully, but these errors were encountered: