Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show graph of the check's metrics #24

Open
timocov opened this issue Aug 16, 2019 · 2 comments
Open

Show graph of the check's metrics #24

timocov opened this issue Aug 16, 2019 · 2 comments

Comments

@timocov
Copy link

timocov commented Aug 16, 2019

I'm not sure that it's right place to fill this issue, but it looks like codechecks' server isn't open-sourced right now...

Some checks (for instance type coverage or file size) have numeric metric values, which can be shown on the graph and then users can compare them as time goes on (for example see how much every commit adds in size to the library or something).

I believe it might be very useful to track changes into historical perspective.

@krzkaczor
Copy link
Member

krzkaczor commented Aug 16, 2019

I'm not sure that it's right place to fill this issue, but it looks like codechecks' server isn't open-sourced right now...

This is exactly the right place ;) We plan on open-sourcing backend parts as well. It will just take more time...

Some checks (for instance type coverage or file size) have numeric metric values, which can be shown on the graph and then users can compare them as time goes on (for example see how much every commit adds in size to the library or something).

Yes! This is definitely something on my mind. I have even initial implementation done here: https://github.com/krzkaczor/cc-stage-playground/pull/9/checks

The idea is that checks maintain ever-growing json array with historic results and then they can plot it. The only problem with this implementation is that it relies on node-gyp as it will generate graphs in node to make them part of the detailed output. The other implementation would be to just generate HTML report but this forces users to click one more time and leave GitHub interface...

Any input from your side? Would leaving GitHub UI acceptable for you?

NOTE: current implementation works on our staging servers.

@timocov
Copy link
Author

timocov commented Aug 19, 2019

Would leaving GitHub UI acceptable for you?

For me it sound good - on non-GitHub page we can make more effective UI, responsive, with support to see custom ranges, click-to-see-commit/pr and so on. https://app.codechecks.io/ is good place for that for me also 🙂

We've implemented something like that for our internal usage, it looks like on the attached screenshots below. That service stores webpack's stats for some bundles/chunks (actually not only webpack - we use that service to monitoring what files was loaded on some our pages also). Every point on the graph is clickable, so if you click on it - you'll see the diff between files (which files was added/removed/changed size).

UI is very primitive though :)

main graph:

main graph

diff view:

diff view

If you'll have any question about that service - please feel free to ask me. I'll happy to help you. Also, if you'll need any help with implementing this (or improving generating graphs) - I'll be here as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants