Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support patterns for speculative branch execution [WIP] #78

Conversation

carmanchris31
Copy link

@carmanchris31 carmanchris31 commented Sep 1, 2020

Closes #77

Let me know if there are any concerns around this. I focused on one function to keep changes minimal and used existing the minimatch instance exposed from glob to avoid introducing additional dependencies, but there are other possibilities if that's desired.

❓ Open question below.

@carmanchris31 carmanchris31 force-pushed the feat/speculative-branch-patterns branch from b9d741b to 6a67e16 Compare September 1, 2020 00:39
@carmanchris31
Copy link
Author

carmanchris31 commented Sep 1, 2020

Actually, I'll probably need someone to explain if the previous behavior if possible. There were no tests to go off of so I may have misinterpreted some things now that I'm reading the description more closely:

Finds speculative branch based on the current branch name. If current branch is not on the list at all, select first. If it is, take the next one. If it's the last one just return undefined.

Should this function/getBaseCommit actually be finding the first branch that intersects with the current one?
That's totally possible to do with git merge-base, but would likely prevent being able to use patterns.
Actually, git branch --contains HEAD would probably be best in that case, and still would allow us to use patterns.

@carmanchris31 carmanchris31 changed the title feat: Support patterns for speculative branch execution feat: Support patterns for speculative branch execution [WIP] Sep 1, 2020
@carmanchris31
Copy link
Author

Actually, I'll probably need someone to explain if the previous behavior if possible. There were no tests to go off of so I may have misinterpreted some things now that I'm reading the description more closely:

Finds speculative branch based on the current branch name. If current branch is not on the list at all, select first. If it is, take the next one. If it's the last one just return undefined.

Should this function/getBaseCommit actually be finding the first branch that intersects with the current one?
That's totally possible to do with git merge-base, but would likely prevent being able to use patterns.
Actually, git branch --contains HEAD would probably be best in that case, and still would allow us to use patterns.

Looks like this may overlap with what was being attempted here: #64

@krzkaczor
Copy link
Member

Hey @carmanchris31,

sorry to keep you waiting but for now development around codechecks is frozen as I work on a totally new version. Feel free to fork this project if you need this feature.

@carmanchris31
Copy link
Author

Hey @carmanchris31,

sorry to keep you waiting but for now development around codechecks is frozen as I work on a totally new version. Feel free to fork this project if you need this feature.

Oh cool thanks for letting me know. Is there any place available to track progress on/contribute to the new version?

@krzkaczor
Copy link
Member

@carmanchris31 not yet but I will circle back to you once the official version will be released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support patterns for speculative branch execution
2 participants