Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary option does not support absolute paths #1698

Open
veehaitch opened this issue Nov 23, 2024 · 0 comments
Open

binary option does not support absolute paths #1698

veehaitch opened this issue Nov 23, 2024 · 0 comments
Assignees
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@veehaitch
Copy link

The new binary option can currently only work if the given path is relative to the working directory. This happens because the wrapper calls the binary with ./$cc_filename: https://github.com/codecov/wrapper/blob/588410fe015a58016d5d0546d84fae5cf8242791/dist/codecov.sh#L222

The option should also support absolute paths.

NB: A hack to work around this issue is to create a symlink to the current working directory:

- run: ln -s /var/lib/codecov-cli/bin/codecovcli .

- uses: codecov/codecov-action@v5
  with:
    binary: ./codecovcli
    # ...
@rohan-at-sentry rohan-at-sentry added Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Report Upload Issues with pre-ingest report uploading Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

3 participants