Skip to content

Commit

Permalink
Upgrade to node-18
Browse files Browse the repository at this point in the history
  • Loading branch information
kiminkim724 committed Feb 5, 2025
1 parent 61cfbd4 commit e40c023
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 12 deletions.
14 changes: 10 additions & 4 deletions firebase.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,18 @@
"hosting": {
"public": "out",
"cleanUrls": true,
"ignore": ["firebase.json", "**/.*", "**/node_modules/**"]
"ignore": [
"firebase.json",
"**/.*",
"**/node_modules/**"
]
},
"functions": {
"predeploy": ["yarn build:functions"],
"predeploy": [
"yarn build:functions"
],
"source": "functions",
"runtime": "nodejs16"
"runtime": "nodejs18"
},
"firestore": {
"rules": "firestore.rules",
Expand Down Expand Up @@ -43,4 +49,4 @@
"extensions": {
"firestore-send-email": "firebase/[email protected]"
}
}
}
6 changes: 4 additions & 2 deletions infra/Dockerfile.firebase
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
FROM andreysenov/firebase-tools:latest-node-16
FROM andreysenov/firebase-tools:latest-node-18

USER root
RUN apt update && apt install -y curl

WORKDIR /app
RUN chown -R node:node .
USER node
USER node

RUN node -v
14 changes: 10 additions & 4 deletions infra/firebase.compose.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,18 @@
"hosting": {
"public": "out",
"cleanUrls": true,
"ignore": ["firebase.json", "**/.*", "**/node_modules/**"]
"ignore": [
"firebase.json",
"**/.*",
"**/node_modules/**"
]
},
"functions": {
"predeploy": ["yarn build:functions"],
"predeploy": [
"yarn build:functions"
],
"source": "functions",
"runtime": "nodejs16"
"runtime": "nodejs18"
},
"firestore": {
"rules": "firestore.rules",
Expand Down Expand Up @@ -62,4 +68,4 @@
"extensions": {
"firestore-send-email": "firebase/[email protected]"
}
}
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"setRole": "ts-node -P tsconfig.script.json scripts/firebase-admin/setRole.ts"
},
"engines": {
"node": ">=16",
"node": ">=18",
"yarn": "^1.22.19"
},
"browserslist": {
Expand Down Expand Up @@ -198,4 +198,4 @@
"resolutions": {
"jackspeak": "2.1.1"
}
}
}

0 comments on commit e40c023

Please sign in to comment.