From e40c023730311b59ae5bb20fc2768091055f4fb3 Mon Sep 17 00:00:00 2001
From: kiminkim724 <kim.ki@husky.neu.edu>
Date: Tue, 4 Feb 2025 20:44:11 -0500
Subject: [PATCH] Upgrade to node-18

---
 firebase.json               | 14 ++++++++++----
 infra/Dockerfile.firebase   |  6 ++++--
 infra/firebase.compose.json | 14 ++++++++++----
 package.json                |  4 ++--
 4 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/firebase.json b/firebase.json
index bc21a5607..3ffbb2ac3 100644
--- a/firebase.json
+++ b/firebase.json
@@ -2,12 +2,18 @@
   "hosting": {
     "public": "out",
     "cleanUrls": true,
-    "ignore": ["firebase.json", "**/.*", "**/node_modules/**"]
+    "ignore": [
+      "firebase.json",
+      "**/.*",
+      "**/node_modules/**"
+    ]
   },
   "functions": {
-    "predeploy": ["yarn build:functions"],
+    "predeploy": [
+      "yarn build:functions"
+    ],
     "source": "functions",
-    "runtime": "nodejs16"
+    "runtime": "nodejs18"
   },
   "firestore": {
     "rules": "firestore.rules",
@@ -43,4 +49,4 @@
   "extensions": {
     "firestore-send-email": "firebase/firestore-send-email@0.1.34"
   }
-}
+}
\ No newline at end of file
diff --git a/infra/Dockerfile.firebase b/infra/Dockerfile.firebase
index d7c1fdada..d56f769cd 100644
--- a/infra/Dockerfile.firebase
+++ b/infra/Dockerfile.firebase
@@ -1,8 +1,10 @@
-FROM andreysenov/firebase-tools:latest-node-16
+FROM andreysenov/firebase-tools:latest-node-18
 
 USER root
 RUN apt update && apt install -y curl
 
 WORKDIR /app
 RUN chown -R node:node .
-USER node
\ No newline at end of file
+USER node
+
+RUN node -v
\ No newline at end of file
diff --git a/infra/firebase.compose.json b/infra/firebase.compose.json
index 2d4b8123a..b6a472df3 100644
--- a/infra/firebase.compose.json
+++ b/infra/firebase.compose.json
@@ -2,12 +2,18 @@
   "hosting": {
     "public": "out",
     "cleanUrls": true,
-    "ignore": ["firebase.json", "**/.*", "**/node_modules/**"]
+    "ignore": [
+      "firebase.json",
+      "**/.*",
+      "**/node_modules/**"
+    ]
   },
   "functions": {
-    "predeploy": ["yarn build:functions"],
+    "predeploy": [
+      "yarn build:functions"
+    ],
     "source": "functions",
-    "runtime": "nodejs16"
+    "runtime": "nodejs18"
   },
   "firestore": {
     "rules": "firestore.rules",
@@ -62,4 +68,4 @@
   "extensions": {
     "firestore-send-email": "firebase/firestore-send-email@0.1.26"
   }
-}
+}
\ No newline at end of file
diff --git a/package.json b/package.json
index e81576ccd..49d78db52 100644
--- a/package.json
+++ b/package.json
@@ -49,7 +49,7 @@
     "setRole": "ts-node -P tsconfig.script.json scripts/firebase-admin/setRole.ts"
   },
   "engines": {
-    "node": ">=16",
+    "node": ">=18",
     "yarn": "^1.22.19"
   },
   "browserslist": {
@@ -198,4 +198,4 @@
   "resolutions": {
     "jackspeak": "2.1.1"
   }
-}
+}
\ No newline at end of file