Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom flyto refactor #248

Merged
merged 16 commits into from
Dec 6, 2019
Merged

Zoom flyto refactor #248

merged 16 commits into from
Dec 6, 2019

Conversation

sashamaryl
Copy link
Collaborator

No description provided.

@sashamaryl
merges in geocoder as component
e9026c5
@sashamaryl
added a savedProviderKey so we can take away the calculation of the l…
3741f74 
…ast provider selected

beginning to refactor all the map movements to make them as few as possible and all in the component did update if possible
@sashamaryl
added smoothFlyTo with curve and speed control so the map flying move…
22c7315 
…ment will be consistent
@sashamaryl
flies in component did update, keychange decider function
f0a6b0b
@sashamaryl
starts clean up
4901f3a
@sashamaryl
map move flow condensed
5e60953 
added conditional in provider click handler so only calls zoom to fit if id is in highlighted list
@sashamaryl
clean up
865ff01
@sashamaryl
fixes a few merge issues
09b7f89 
runs prettier
@alexjball
Copy link
Member

With this PR, when clicking an icon to deselect, it animates before changing color. Previously, or when deselecting from the provider list, the icon just changes color.

alexjball
alexjball approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@alexjball alexjball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Icon deselection works as expected now.

@alexjball alexjball merged commit 8c3ec86 into codeforboston:reboot Dec 6, 2019
@alexjball alexjball mentioned this pull request Dec 7, 2019
Merged
@sashamaryl sashamaryl linked an issue Feb 12, 2020 that may be closed by this pull request
Provider icons lose assigned color #143
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjball alexjball alexjball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider icons lose assigned color
2 participants
@sashamaryl @alexjball