You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been several tests created for XML earning history profiles that we received from the Social Security website. These were merged in #129 but the tests are still "red" in TravisCI because the values from this app do not match the Prototype Observable Notebook. That is a bit strange because the calculation functions were taken directly out of that, though the AIME function was updated/improved.
Run the tests with npm test.
Test suites
John Q. Public (Full Retirement.xml) - these work in the observable calculator but we don't really trust the values to be authoritative because it is not a real person and the values in the XML do not match the values for the same earnings in Detailed Calculator linked below. It is not WEP affected.
getAIMEFromEarnings test solo function, this is a stripped down example test.
To Do's
Fix the tests about substantial earnings: getYearsSE() needs to be able to parse the XML-like JSON object, not just simple key-values. Right now it is always returning 20 which is bad.
(harder) If any differences remain, figure out why any other of the above tests from Improve Test Suite (WIP) #129 are not matching the observable values and make them run green.
(easiest) Add the three new tests below from the Social Security detail calculator
We also have three fresh new files from the detailed calculator at https://cfb-public.slack.com/archives/CRBK25C2G/p1575918023000400 which you could convert to JSON by adding a new cell like fastXml.parse(\` to the observable notebook, running the cell, and clicking the little button on the left to download the JSON and copy/paste it into a test.
The text was updated successfully, but these errors were encountered:
There have been several tests created for XML earning history profiles that we received from the Social Security website. These were merged in #129 but the tests are still "red" in TravisCI because the values from this app do not match the Prototype Observable Notebook. That is a bit strange because the calculation functions were taken directly out of that, though the AIME function was updated/improved.
Run the tests with
npm test
.Test suites
To Do's
20
which is bad.We also have three fresh new files from the detailed calculator at https://cfb-public.slack.com/archives/CRBK25C2G/p1575918023000400 which you could convert to JSON by adding a new cell like
![image](https://user-images.githubusercontent.com/283343/71445112-e5eaf100-26e4-11ea-9ca1-f35232d0151a.png)
fastXml.parse(\
` to the observable notebook, running the cell, and clicking the little button on the left to download the JSON and copy/paste it into a test.The text was updated successfully, but these errors were encountered: