Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoted name and variant character support #2555

Conversation

SanjulaGanepola
Copy link
Member

@SanjulaGanepola SanjulaGanepola commented Mar 6, 2025

Changes

TODO:

  • Add some new tests!
  • Review for other spots where triple quotes is needed
  • Review use of escapePath vs escapeForShell
  • Review what to do in the case runSQL is used
  • Improve quoted name regex

How to test this PR

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@SanjulaGanepola SanjulaGanepola temporarily deployed to testing_environment March 6, 2025 11:49 — with GitHub Actions Inactive
@SanjulaGanepola SanjulaGanepola marked this pull request as ready for review March 6, 2025 11:59
@SanjulaGanepola SanjulaGanepola added the build Build will be available inside PR. label Mar 6, 2025
@SanjulaGanepola SanjulaGanepola marked this pull request as draft March 6, 2025 12:01
@SanjulaGanepola
Copy link
Member Author

Closing this for now and will re-open smaller PRs with individual changes so it is easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build will be available inside PR.
Projects
None yet
1 participant