Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[박재현] Sprint1 #74

Conversation

reenact11
Copy link
Collaborator

@reenact11 reenact11 commented May 6, 2024

코드리뷰 해주신 내용 일부 수정해서 다시 PR 했습니다 ㅎㅎ

reenact11 added 3 commits May 7, 2024 00:46
fonts.css와 reset.css로 코드 분리, 불필요한 속성값 제거(font-weight, display:flex),
0px 표기 0으로 수정, .footer__policy 하위 a태그에 .policy__links 클래스 추가 및 기존 코드 삭제
link태그에 reset.css와 fonts.css 추가, 기존 개행에 사용했던 패딩값을 삭제함에 따라 br태그 추가,
footer__policy 하위 a 태그에 policy__links 클래스 추가, footer__social 로고 이미지 누락된 height값 추가
@reenact11 reenact11 closed this May 6, 2024
@reenact11 reenact11 reopened this May 6, 2024
@reenact11 reenact11 requested a review from 13akstjq May 6, 2024 16:25
@reenact11 reenact11 self-assigned this May 6, 2024
@13akstjq 13akstjq merged commit ed42a74 into codeit-bootcamp-frontend:Basic-박재현 May 7, 2024
1 check passed
@reenact11 reenact11 deleted the Basic-박재현-sprint1 branch May 24, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants