Skip to content

Commit 4f1aca8

Browse files
committed
Removed firefase-core dependency when using fcm
Not necessary for messaging, and also triggers imports of other libs that can cause problems during approval. E.g. ADs ID.
1 parent 892fa4c commit 4f1aca8

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

maven/codenameone-maven-plugin/src/main/java/com/codename1/builders/AndroidGradleBuilder.java

-12
Original file line numberDiff line numberDiff line change
@@ -1330,19 +1330,7 @@ public void usesClassMethod(String cls, String method) {
13301330
if (!request.getArg("android.xgradle", "").contains("apply plugin: 'com.google.gms.google-services'")) {
13311331
request.putArgument("android.xgradle", request.getArg("android.xgradle", "") + "\napply plugin: 'com.google.gms.google-services'\n");
13321332
}
1333-
if (!request.getArg("gradleDependencies", "").contains("com.google.firebase:firebase-core")) {
1334-
debug("Adding firebase core to gradle dependencies.");
1335-
debug("Play services version: " + request.getArg("var.android.playServicesVersion", ""));
1336-
debug("gradleDependencies before: "+request.getArg("gradleDependencies", ""));
13371333

1338-
request.putArgument(
1339-
"gradleDependencies",
1340-
request.getArg("gradleDependencies", "") +
1341-
"\n"+compile+" \"com.google.firebase:firebase-core:" +
1342-
request.getArg("android.firebaseCoreVersion", playServicesVersion) + "\"\n"
1343-
);
1344-
debug("gradleDependencies after: "+request.getArg("gradleDependencies", ""));
1345-
}
13461334
if (!request.getArg("gradleDependencies", "").contains("com.google.firebase:firebase-messaging")) {
13471335
request.putArgument(
13481336
"gradleDependencies",

0 commit comments

Comments
 (0)