Skip to content

Commit 60727b2

Browse files
committed
Fixed firebase regression in AndroidGradleBuilder.
1 parent 9154995 commit 60727b2

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

maven/codenameone-maven-plugin/src/main/java/com/codename1/builders/AndroidGradleBuilder.java

+13-2
Original file line numberDiff line numberDiff line change
@@ -1168,11 +1168,22 @@ public void usesClassMethod(String cls, String method) {
11681168
debug("Adding firebase core to gradle dependencies.");
11691169
debug("Play services version: " + request.getArg("var.android.playServicesVersion", ""));
11701170
debug("gradleDependencies before: "+request.getArg("gradleDependencies", ""));
1171-
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-core:${var.android.firebaseCoreVersion}\"\n");
1171+
1172+
request.putArgument(
1173+
"gradleDependencies",
1174+
request.getArg("gradleDependencies", "") +
1175+
"\n"+compile+" \"com.google.firebase:firebase-core:" +
1176+
request.getArg("android.firebaseCoreVersion", playServicesVersion) + "\"\n"
1177+
);
11721178
debug("gradleDependencies after: "+request.getArg("gradleDependencies", ""));
11731179
}
11741180
if (!request.getArg("gradleDependencies", "").contains("com.google.firebase:firebase-messaging")) {
1175-
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-messaging:${var.android.firebaseMessagingVersion}\"\n");
1181+
request.putArgument(
1182+
"gradleDependencies",
1183+
request.getArg("gradleDependencies", "") +
1184+
"\n"+compile+" \"com.google.firebase:firebase-messaging:" +
1185+
request.getArg("android.firebaseMessagingVersion", playServicesVersion) + "\"\n"
1186+
);
11761187
}
11771188
}
11781189

0 commit comments

Comments
 (0)