@@ -271,7 +271,7 @@ public File getGradleProjectDirectory() {
271
271
272
272
private static final boolean isMac ;
273
273
274
- private String playServicesVersion = "16 .0.0 " ;
274
+ private String playServicesVersion = "12 .0.1 " ;
275
275
private static final Map <String ,String > defaultPlayServiceVersions = new HashMap <>();
276
276
static {
277
277
// Defaults obtained from https://developers.google.com/android/guides/setup
@@ -325,6 +325,12 @@ public File getGradleProjectDirectory() {
325
325
defaultPlayServiceVersions .put ("vision" , "20.1.3" );
326
326
defaultPlayServiceVersions .put ("wallet" , "19.1.0" );
327
327
defaultPlayServiceVersions .put ("wearable" , "18.0.0" );
328
+
329
+ // TODO: See what an appropriate default version is for firebase
330
+ // Setting to 12.0.1 for now only to match the previous google play services default.
331
+ defaultPlayServiceVersions .put ("firebase-core" , "12.0.1" );
332
+ defaultPlayServiceVersions .put ("firebase-messaging" , "12.0.1" );
333
+ defaultPlayServiceVersions .put ("gcm" , "12.0.1" );
328
334
}
329
335
330
336
private Map <String ,String > playServiceVersions = new HashMap <>();
@@ -1129,6 +1135,8 @@ public void usesClassMethod(String cls, String method) {
1129
1135
}
1130
1136
}
1131
1137
request .putArgument ("android.playServicesVersion" , playServicesVersion );
1138
+ request .putArgument ("android.firebaseCoreVersion" , request .getArg ("android.firebaseCoreVersion" , getDefaultPlayServiceVersion ("firebase-core" )));
1139
+ request .putArgument ("android.firebaseMessagingVersion" , request .getArg ("android.firebaseMessagingVersion" , getDefaultPlayServiceVersion ("firebase-messaging" )));
1132
1140
1133
1141
debug ("-----USING PLAY SERVICES VERSION " +playServicesVersion +"----" );
1134
1142
@@ -1156,11 +1164,11 @@ public void usesClassMethod(String cls, String method) {
1156
1164
debug ("Adding firebase core to gradle dependencies." );
1157
1165
debug ("Play services version: " + request .getArg ("var.android.playServicesVersion" , "" ));
1158
1166
debug ("gradleDependencies before: " +request .getArg ("gradleDependencies" , "" ));
1159
- request .putArgument ("gradleDependencies" , request .getArg ("gradleDependencies" , "" ) + "\n " +compile +" \" com.google.firebase:firebase-core:${var.android.playServicesVersion }\" \n " );
1167
+ request .putArgument ("gradleDependencies" , request .getArg ("gradleDependencies" , "" ) + "\n " +compile +" \" com.google.firebase:firebase-core:${var.android.firebaseCoreVersion }\" \n " );
1160
1168
debug ("gradleDependencies after: " +request .getArg ("gradleDependencies" , "" ));
1161
1169
}
1162
1170
if (!request .getArg ("gradleDependencies" , "" ).contains ("com.google.firebase:firebase-messaging" )) {
1163
- request .putArgument ("gradleDependencies" , request .getArg ("gradleDependencies" , "" ) + "\n " +compile +" \" com.google.firebase:firebase-messaging:${var.android.playServicesVersion }\" \n " );
1171
+ request .putArgument ("gradleDependencies" , request .getArg ("gradleDependencies" , "" ) + "\n " +compile +" \" com.google.firebase:firebase-messaging:${var.android.firebaseMessagingVersion }\" \n " );
1164
1172
}
1165
1173
}
1166
1174
@@ -4090,6 +4098,10 @@ private void initPlayServiceVersions(BuildRequest request) {
4090
4098
String playServiceKey = arg .substring ("android.playService." .length ());
4091
4099
if (playServiceKey .equals ("appInvite" )) {
4092
4100
playServiceKey = "app-invite" ;
4101
+ } else if (playServiceKey .equals ("firebaseCore" )) {
4102
+ playServiceKey = "firebase-core" ;
4103
+ } else if (playServiceKey .equals ("firebaseMessaging" )) {
4104
+ playServiceKey = "firebase-messaging" ;
4093
4105
}
4094
4106
String playServiceValue = request .getArg (arg , null );
4095
4107
if (playServiceValue == null || "true" .equals (playServiceValue ) || "false" .equals (playServiceValue )) {
0 commit comments