Skip to content

Commit fbb4b75

Browse files
committed
Set default playServicesVersion back to 12.0.1.
Separated out versions for firebase-core and firebase-messaging, setting default at 12.0.1. Will investigate compatible new version for next release.
1 parent b723c9e commit fbb4b75

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

maven/codenameone-maven-plugin/src/main/java/com/codename1/builders/AndroidGradleBuilder.java

+15-3
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ public File getGradleProjectDirectory() {
271271

272272
private static final boolean isMac;
273273

274-
private String playServicesVersion = "16.0.0";
274+
private String playServicesVersion = "12.0.1";
275275
private static final Map<String,String> defaultPlayServiceVersions = new HashMap<>();
276276
static {
277277
// Defaults obtained from https://developers.google.com/android/guides/setup
@@ -325,6 +325,12 @@ public File getGradleProjectDirectory() {
325325
defaultPlayServiceVersions.put("vision", "20.1.3");
326326
defaultPlayServiceVersions.put("wallet", "19.1.0");
327327
defaultPlayServiceVersions.put("wearable", "18.0.0");
328+
329+
// TODO: See what an appropriate default version is for firebase
330+
// Setting to 12.0.1 for now only to match the previous google play services default.
331+
defaultPlayServiceVersions.put("firebase-core", "12.0.1");
332+
defaultPlayServiceVersions.put("firebase-messaging", "12.0.1");
333+
defaultPlayServiceVersions.put("gcm", "12.0.1");
328334
}
329335

330336
private Map<String,String> playServiceVersions = new HashMap<>();
@@ -1129,6 +1135,8 @@ public void usesClassMethod(String cls, String method) {
11291135
}
11301136
}
11311137
request.putArgument("android.playServicesVersion", playServicesVersion);
1138+
request.putArgument("android.firebaseCoreVersion", request.getArg("android.firebaseCoreVersion", getDefaultPlayServiceVersion("firebase-core")));
1139+
request.putArgument("android.firebaseMessagingVersion", request.getArg("android.firebaseMessagingVersion", getDefaultPlayServiceVersion("firebase-messaging")));
11321140

11331141
debug("-----USING PLAY SERVICES VERSION "+playServicesVersion+"----");
11341142

@@ -1156,11 +1164,11 @@ public void usesClassMethod(String cls, String method) {
11561164
debug("Adding firebase core to gradle dependencies.");
11571165
debug("Play services version: " + request.getArg("var.android.playServicesVersion", ""));
11581166
debug("gradleDependencies before: "+request.getArg("gradleDependencies", ""));
1159-
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-core:${var.android.playServicesVersion}\"\n");
1167+
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-core:${var.android.firebaseCoreVersion}\"\n");
11601168
debug("gradleDependencies after: "+request.getArg("gradleDependencies", ""));
11611169
}
11621170
if (!request.getArg("gradleDependencies", "").contains("com.google.firebase:firebase-messaging")) {
1163-
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-messaging:${var.android.playServicesVersion}\"\n");
1171+
request.putArgument("gradleDependencies", request.getArg("gradleDependencies", "") + "\n"+compile+" \"com.google.firebase:firebase-messaging:${var.android.firebaseMessagingVersion}\"\n");
11641172
}
11651173
}
11661174

@@ -4090,6 +4098,10 @@ private void initPlayServiceVersions(BuildRequest request) {
40904098
String playServiceKey = arg.substring("android.playService.".length());
40914099
if (playServiceKey.equals("appInvite")) {
40924100
playServiceKey = "app-invite";
4101+
} else if (playServiceKey.equals("firebaseCore")) {
4102+
playServiceKey = "firebase-core";
4103+
} else if (playServiceKey.equals("firebaseMessaging")) {
4104+
playServiceKey = "firebase-messaging";
40934105
}
40944106
String playServiceValue = request.getArg(arg, null);
40954107
if (playServiceValue == null || "true".equals(playServiceValue) || "false".equals(playServiceValue)) {

0 commit comments

Comments
 (0)