Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Better output when installing with NPM #5537

Open
edvincent opened this issue Sep 6, 2022 · 1 comment
Open

[Fix]: Better output when installing with NPM #5537

edvincent opened this issue Sep 6, 2022 · 1 comment
Assignees
Labels
enhancement Some improvement that isn't a feature
Milestone

Comments

@edvincent
Copy link
Contributor

Why do you want this feature?

In the postinstall.sh script that is used when installing with npm, we use nested commands to install vscode and its extensions - see code

As reported in #5530 (and more in #5533), installs were passing but actually failing - and only was seen during runtime.

The nested installs were failing, but the errors weren't being bubbled-up... Was only seen when using --foreground-scripts.

What is your suggestion?

  • NPM 8 needs to be passed --foreground-scripts to actually see the output of the nested. We should update the doc to show that as a troubleshooting step in here: https://coder.com/docs/code-server/latest/npm#debugging-install-issues-with-npm
  • I would expect the overall script to have a non-0 exit code if any of the nested scripts failed (i.e. they themselves had a non-0 exit code) which would make the overall npm install fail. Need to investigate that.

Are there any workarounds to get this functionality today?

  • Pass --foreground-scripts and read carefully :(

Are you interested in submitting a PR for this?

Yes

@edvincent edvincent added the enhancement Some improvement that isn't a feature label Sep 6, 2022
@jsjoeio jsjoeio added this to the September 2022 milestone Sep 6, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 6, 2022

This seems like a nice UX improvement!

@jsjoeio jsjoeio modified the milestones: September 2022, October 2022 Sep 30, 2022
@jsjoeio jsjoeio modified the milestones: October 2022, On Deck Oct 10, 2022
@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
@code-asher code-asher reopened this Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

3 participants