[Bug]: terminal not opening on 4.9.0 on macOS (github release and homebrew) #5843

jsjoeio · 2022-12-07T17:51:01Z

Is there an existing issue for this?

I have searched the existing issues

OS/Web Information

Web Browser: Chrome
Local OS: macOS
Remote OS: macOS
Remote Architecture: n/a
code-server --version: 4.9.0

Steps to Reproduce

brew upgrade code-server
code-server
open Integrated Terminal

Expected

The terminal should load

Actual

It doesn't load

Logs

  ERR TypeError: Cannot read properties of undefined (reading 'cell')
    at c.getFont (terminalConfigHelper.ts:188:73)
    at Ui.getFont (xtermTerminal.ts:416:29)
    at Ki._getDimension (terminalInstance.ts:698:40)
    at Ki._evaluateColsAndRows (terminalInstance.ts:649:26)
    at Ki.layout (terminalInstance.ts:1875:30)
    at Ki._open (terminalInstance.ts:1072:9)
    at Ki.setVisible (terminalInstance.ts:1350:9)
    at g.setInput (terminalEditor.ts:78:39)
    at async a.doSetInput (editorPanes.ts:353:4)
    at async a.doOpenEditor (editorPanes.ts:222:34)

Screenshot/Video

Does this issue happen in VS Code or GitHub Codespaces?

I cannot reproduce this in VS Code.
I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

I am using HTTPS.

Notes

No response

The text was updated successfully, but these errors were encountered:

jsjoeio · 2022-12-07T17:53:55Z

First thought is to test the macOS binary in the releases to see if this is specific to using code-server on Homebrew.

jsjoeio · 2022-12-07T17:57:28Z

Confirmed also broken on macOS release.

jsjoeio · 2022-12-07T17:58:05Z

However, it is working on Linux so that's good.

I'll check npm next.

jsjoeio · 2022-12-07T18:01:13Z

npm is also broken, which means anyone on AUR or Homebrew will also have a broken terminal

jsjoeio · 2022-12-07T18:05:12Z

Next step is to see if this happens locally on macOS when I develop code-server. That'll tell me if this is only for production builds.

jsjoeio · 2022-12-07T18:09:30Z

Since I develop code-server with code-server and Homebrew doesn't maintain versions, I'll have to download via npm and downgrade to 4.8.3

jsjoeio · 2022-12-07T18:22:09Z

Hmm...terminal works just fine in development 🤔

So something must be up with the build process.

jsjoeio · 2022-12-07T18:26:54Z

Next thing is to download the npm artifact that was used to create the release packages here: https://github.com/coder/code-server/actions/runs/3624825961

jsjoeio · 2022-12-07T18:29:18Z

Hmm...so that one works:

download artifact
unzip
cd release && yarn
node . --port 3002

To be clear this is the npm artifact after we modify the version 🤔 That could mean something during the macOS build and then also when we download the artifact before publishing to npm.

jsjoeio · 2022-12-07T18:39:39Z

Next step is to try replicating the "publish to npm" steps by downloading the package.tar.gz from releases and testing locally.

jsjoeio · 2022-12-07T18:44:56Z

Tried this:

download package.tar.gz from 4.9.0 release
unzip
cd && yarn
node . --port 3002

and it worked as expected

Very confused 🤔

jsjoeio · 2022-12-07T22:30:34Z

Fixed via #5844

jsjoeio · 2022-12-09T15:12:58Z

Still happening but i did notice that if i use yarn after downloading the github release for macOS, it works. We'll have to investigate further.

jsjoeio · 2022-12-09T17:49:42Z

We've been digging in for the last two days and here's a brief summary of what we know:

macos-amd64 seems to be affected but if you rm -rf node_modules and run yarn at the root and lib/vscode the terminal loads
we're not sure if this is caused by npm but it does seem like having native dependencies fixes the issue
we don't know if upgrading to 1.74 will fix it (as an alternative)
the npm / yarn situation is tricky and is hard to debug

jsjoeio · 2022-12-09T17:51:00Z

Investigation Notes

Part of me thinks I should revert these changes and build a standalone release on my macOS and see if that works.

You think so?

Actually no, let's start from the beginning...You released 4.9.0 and you noticed it didn't work via Homebrew or macOS, right?

Exactly

Okay so let's start there. Do this:

Download the macos-amd64 release from 4.9.0
Unzip
cd && ./bin/code-server --port 8080
Open the Integrated Terminal

Then tell me what happens.

Terminal is broken

Cool. We expected that. Are there any logs in the browser console?

Yup. Let me post it.

log.ts:324   ERR Cannot read properties of undefined (reading 'cell'): TypeError: Cannot read properties of undefined (reading 'cell')
    at c.getFont (http://localhost:8080/stable-6261075646f055b99068d3688932416f2346dd3b/static/out/vs/workbench/workbench.web.main.js:3249:11304)
    at Ui.getFont (http://localhost:8080/stable-6261075646f055b99068d3688932416f2346dd3b/static/out/vs/workbench/workbench.web.main.js:2008:28624)
    at Ki._getDimension (http://localhost:8080/stable-6261075646f055b99068d3688932416f2346dd3b/static/out/vs/workbench/workbench.web.main.js:3141:42090)
    at Ki._evaluateColsAndRows (http://localhost:8080/stable-6261075646f055b99068d3688932416f2346dd3b/static/out/vs/workbench/workbench.web.main.js:3141:41197)
    at Ki.layout (http://localhost:8080/stable-6261075646f055b99068d3688932416f2346dd3b/static/out/vs/workbench/workbench.web.main.js:3144:2577)
    at Ki._open (http://localhost:8080/stable-6261075646f055b99068d3688932416f2346dd3b/static/out/vs/workbench/workbench.web.main.js:3141:50915)
    at Ki._createXterm (http://localhost:8080/stable-6261075646f055b99068d3688932416f2346dd3b/static/out/vs/workbench/workbench.web.main.js:3141:45717)

Nice. Okay I've seen that before. Did you check upstream to see if there's an issue about it?

Yes, I found this.

microsoft/vscode#161049

Nice! If you pay attention to the PR description for the fix though, see this:

Note that this doesn't fix the underling issue but can give us better exceptions thrown at the right place.

Makes me think it still could be unresolved 🤔

What next?

I was messing around and might know of a workaround. Can you do this:

cd into that unzipped release you have locally
rm -rf node_modules lib/vscode/node_modules
yarn && cd lib/vscode && yarn
./bin/code-server --port 8080
open integrated terminal

Still broken

Really?? I thought that might work. Okay can you try the same thing but download the macos-amd64 4.9.1 draft release I have?

Sure!

What happens?

So 4.9.1 has a broken terminal but let me try your node_modules trick.

Okay then report back.

Still broken.

❯ yarn && cd lib/vscode && yarn
yarn install v1.22.18
warning npm-shrinkwrap.json found. This will not be updated or respected. See https://yarnpkg.com/en/docs/migrating-from-npm for more information.
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning " > @coder/[email protected]" has unmet peer dependency "@google-cloud/logging@^9.2.1".
[5/5] 🔨  Building fresh packages...
success Saved lockfile.
$ sh ./postinstall.sh
Installing Code dependencies...
User agent: yarn/1.22.18 npm/? node/v16.17.0 darwin x64
yarn install v1.22.18
warning npm-shrinkwrap.json found. This will not be updated or respected. See https://yarnpkg.com/en/docs/migrating-from-npm for more information.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "@microsoft/1ds-core-js > @microsoft/[email protected]" has unmet peer dependency "tslib@*".
[4/4] 🔨  Building fresh packages...
warning Your current version of Yarn is out of date. The latest version is "1.22.19", while you're on "1.22.18".
info To upgrade, run the following command:
$ brew upgrade yarn
✨  Done in 32.86s.
User agent: yarn/1.22.18 npm/? node/v16.17.0 darwin x64
yarn install v1.22.18
warning npm-shrinkwrap.json found. This will not be updated or respected. See https://yarnpkg.com/en/docs/migrating-from-npm for more information.
[1/4] 🔍  Resolving packages...
error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
You may not have the required dependencies to build the native modules.
Please see https://github.com/coder/code-server/blob/main/docs/npm.md
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Dang it. I thought that worked. Okay well I need a lunch break so we'll continue after this.

sounds good!

jsjoeio · 2022-12-09T18:59:58Z

Idea after lunch break - double-check this issue doesn't exist in dev mode locally

if terminal does work, try copying node_modules into the 4.9.1 and seeing if that fixes it

jsjoeio · 2022-12-09T20:20:34Z

Investigation - round 2

So when developing locally against `main` and running `yarn watch` it works 🤔

Interesting...Want to try copying those lib/vscode/node_modules into the 4.9.1's directory and see if that works?

Sure.

jsjoeio · 2022-12-09T20:21:42Z

Investigation - round 2

So when developing locally against `main` and running `yarn watch` it works 🤔

Interesting...Want to try copying those lib/vscode/node_modules into the 4.9.1's directory and see if that works?

Woah! That worked!

Interesting...so that seems to be a modules issue at the lib/vscode level 🤔 One thing too is you're using yarn with yarn watch so...

so now what?

We're going to try something funky. Take broken node_modules aka some from 4.9.0 lib/vscode and copy on top of lib/vscode/node_modules in your dev build locally. Then it will only try to replace ones that conflict.

interesting...okay

One other thing we noticed was there was some caching of the modules in the browser so when i got it working but then went to Incognito it stopped.

what next?

Copy the lib/vscode/node_modules/xterm-* modules into lib/vscode/remote/web/node_modules and see if it breaks as expected.

it worked meaning it is still broken

what next?

I have to run, but try replacing each "back-up-xterm" module back into your local lib/vscode/remote/web/node_modules one by one and refresh the page each time to see if you can isolate which package is messed up (because we checked package.json and there were all the same versions.

Okay cool we'll do that when you get back

see ya!

jsjoeio · 2022-12-09T23:59:17Z

Investigation Notes - round 3

So turns it out to be a discreprency with xterm versions, similar to this #5530

We just tried another run and ripgrep failed in CI so none of lib/vscode/node_modules were installed but CI still passed and our native modules test passed so we need to change that back to --list-extensions.

Re-running again to see what happens
https://github.com/coder/code-server/actions/runs/3661582333

jsjoeio · 2022-12-10T00:05:55Z

TURNS OUT THAT WORKED.

Followup for monday:

add back --list-extensions (--help only tests native modules for code-server, add note)
run e2e on macOS runner (so we don't have to test manually)

maxbane · 2022-12-11T00:07:05Z

I just upgraded code-server to 4.9.0 on an Ubuntu 22.04.1 host (via install.sh), and the terminal no longer works in my iPadOS client. Thought I'd mention it here in case it's related (something about both clients using safari webkit?), but also happy to open a separate issue if preferable.

EDIT: I actually opened a separate issue for iPadOS, because I noticed at least one other bug (unresolved version string in the About window): #5863

jsjoeio · 2022-12-12T16:08:46Z

Apologies! I think that's terminal gpu rendering related. I think I tagged you in another comment:

Settings > Terminal > Gpu Acceleration "off" and now it renders correctly on iPad

Version has been fixed and will be out in the next release!

jsjoeio · 2022-12-15T20:35:13Z

Tested and verified this will be fixed in 4.9.1

jsjoeio added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Dec 7, 2022

jsjoeio self-assigned this Dec 7, 2022

jsjoeio removed the triage This issue needs to be triaged by a maintainer label Dec 7, 2022

jsjoeio added this to the December 2022 milestone Dec 7, 2022

jsjoeio changed the title ~~[Bug]: terminal not opening on 4.9.0~~ [Bug]: terminal not opening on 4.9.0 on macOS (release and homebrew) Dec 7, 2022

jsjoeio added the high-priority This issue needs to be resolved ASAP label Dec 7, 2022

jsjoeio changed the title ~~[Bug]: terminal not opening on 4.9.0 on macOS (release and homebrew)~~ [Bug]: terminal not opening on 4.9.0 on macOS (github release, homebrew and npm) Dec 7, 2022

jsjoeio changed the title ~~[Bug]: terminal not opening on 4.9.0 on macOS (github release, homebrew and npm)~~ [Bug]: terminal not opening on 4.9.0 on macOS (github release and homebrew) Dec 7, 2022

jsjoeio closed this as completed Dec 7, 2022

jsjoeio reopened this Dec 9, 2022

maxbane mentioned this issue Dec 13, 2022

[Bug]: 4.9.0 is broken in iPadOS client (at least Terminal and About window) #5863

Closed

4 tasks

jsjoeio closed this as completed Dec 15, 2022

jsjoeio modified the milestones: December 2022, 4.9.1 Dec 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: terminal not opening on 4.9.0 on macOS (github release and homebrew) #5843

[Bug]: terminal not opening on 4.9.0 on macOS (github release and homebrew) #5843

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 9, 2022 •

edited

Loading

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 9, 2022 •

edited

Loading

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 10, 2022

maxbane commented Dec 11, 2022 •

edited

Loading

jsjoeio commented Dec 12, 2022

jsjoeio commented Dec 15, 2022

[Bug]: terminal not opening on 4.9.0 on macOS (github release and homebrew) #5843

[Bug]: terminal not opening on 4.9.0 on macOS (github release and homebrew) #5843

Comments

jsjoeio commented Dec 7, 2022

Is there an existing issue for this?

OS/Web Information

Steps to Reproduce

Expected

Actual

Logs

Screenshot/Video

Does this issue happen in VS Code or GitHub Codespaces?

Are you accessing code-server over HTTPS?

Notes

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 7, 2022

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 9, 2022 • edited Loading

Investigation Notes

You think so?

Exactly

Terminal is broken

Yup. Let me post it.

Yes, I found this.

What next?

Still broken

Sure!

So 4.9.1 has a broken terminal but let me try your node_modules trick.

Still broken.

sounds good!

jsjoeio commented Dec 9, 2022

jsjoeio commented Dec 9, 2022

Investigation - round 2

So when developing locally against main and running yarn watch it works 🤔

Sure.

jsjoeio commented Dec 9, 2022 • edited Loading

Investigation - round 2

So when developing locally against main and running yarn watch it works 🤔

Woah! That worked!

so now what?

interesting...okay

what next?

it worked meaning it is still broken

what next?

Okay cool we'll do that when you get back

jsjoeio commented Dec 9, 2022

Investigation Notes - round 3

jsjoeio commented Dec 10, 2022

maxbane commented Dec 11, 2022 • edited Loading

jsjoeio commented Dec 12, 2022

jsjoeio commented Dec 15, 2022

jsjoeio commented Dec 9, 2022 •

edited

Loading

So when developing locally against `main` and running `yarn watch` it works 🤔

jsjoeio commented Dec 9, 2022 •

edited

Loading

So when developing locally against `main` and running `yarn watch` it works 🤔

maxbane commented Dec 11, 2022 •

edited

Loading