Skip to content

Update Code to 1.100 #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benz0li opened this issue Apr 27, 2025 · 5 comments
Open

Update Code to 1.100 #7329

benz0li opened this issue Apr 27, 2025 · 5 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@benz0li
Copy link
Contributor

benz0li commented Apr 27, 2025

What is your suggestion?

Update Code to 1.100

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

@benz0li benz0li added the enhancement Some improvement that isn't a feature label Apr 27, 2025
@benz0li
Copy link
Contributor Author

benz0li commented Apr 27, 2025

Expected release date: 05/07 (this may change)

microsoft/vscode#247207

@benz0li
Copy link
Contributor Author

benz0li commented Apr 27, 2025

Note to self:

  1. Check Node.js version in lib/vscode/remote/.npmrc
    • Update .node-version and package.json accordingly
  2. Check https://github.com/VSCodium/vscodium/blob/master/patches/linux/reh/s390x/arch-4-s390x-package.json.patch

@sourishkrout
Copy link

As per my convo with @code-asher, Signature Verification which is in fact unsupported by OpenVSX might break for all platforms in 1.100: #7213 (comment).

@benz0li
Copy link
Contributor Author

benz0li commented May 3, 2025

Note to self:

  1. Include new patch patches/signature-verification.diff
Disable signature verification.

Extension signature verification is now mandatory for all platforms and needs to be disabled.

Index: code-server/lib/vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts
===================================================================
--- code-server.orig/lib/vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts
+++ code-server/lib/vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts
@@ -34,6 +34,7 @@ import {
        ExtensionSignatureVerificationCode,
        computeSize,
        IAllowedExtensionsService,
+       // @ts-expect-error no-unused-variable
        VerifyExtensionSignatureConfigKey,
        shouldRequireRepositorySignatureFor,
 } from '../common/extensionManagement.js';
@@ -87,6 +88,7 @@ export class ExtensionManagementService
                @IDownloadService private downloadService: IDownloadService,
                @IInstantiationService private readonly instantiationService: IInstantiationService,
                @IFileService private readonly fileService: IFileService,
+               // @ts-expect-error no-unused-variable
                @IConfigurationService private readonly configurationService: IConfigurationService,
                @IExtensionGalleryManifestService protected readonly extensionGalleryManifestService: IExtensionGalleryManifestService,
                @IProductService productService: IProductService,
@@ -331,8 +333,7 @@ export class ExtensionManagementService
 
        private async downloadExtension(extension: IGalleryExtension, operation: InstallOperation, verifySignature: boolean, clientTargetPlatform?: TargetPlatform): Promise<{ readonly location: URI; readonly verificationStatus: ExtensionSignatureVerificationCode | undefined }> {
                if (verifySignature) {
-                       const value = this.configurationService.getValue(VerifyExtensionSignatureConfigKey);
-                       verifySignature = isBoolean(value) ? value : true;
+                       verifySignature = false;
                }
                const { location, verificationStatus } = await this.extensionsDownloader.download(extension, operation, verifySignature, clientTargetPlatform);
                const shouldRequireSignature = shouldRequireRepositorySignatureFor(extension.private, await this.extensionGalleryManifestService.getExtensionGalleryManifest());

Otherwise code-server on Linux will also error with

[...]
9.805 [2025-05-03T06:59:13.005Z] error parent:70 Uncaught exception: Signature verification was not executed.
9.805 [2025-05-03T06:59:13.006Z] error parent:70 SignatureVerificationInternal: Signature verification was not executed.
9.805     at xl.xb (file:///opt/code-server/lib/vscode/out/server-main.js:55:16152)
9.805     at async xl.wb (file:///opt/code-server/lib/vscode/out/server-main.js:55:15115)

when installing an extension.

@benz0li
Copy link
Contributor Author

benz0li commented May 3, 2025

@sourishkrout You may test at https://coder.jupyter.b-data.ch/ (Image R 4.5 + Python 3.12 (jupyterlab/r/verse:test-devtools)) where code-server-4.101.0-rc.1-linux-amd64.tar.gz with Code 1.101.0 is deployed.
👉 I have whitelisted your GitHub account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

2 participants